| Message ID | 1362397218-5675-1-git-send-email-josephl@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 03/04/2013 04:40 AM, Joseph Lo wrote: > Adding suspend to ram support for Tegra platform. There are three suspend nit: s/ram/RAM/ > mode for Tegra. The difference were below. Does this patch work for all 3 upstream Tegras, or just Tegra20 (or 20+30?). > diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c > + tegra_init_suspend(); That call isn't ifdef'd on anything ... > diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c > +static void tegra_suspend_enter_lp2(void) > +{ > + tegra_set_cpu_in_lp2(0); > +} > + > +static void tegra_suspend_exit_lp2(void) > +{ > + tegra_clear_cpu_in_lp2(0); > +} Are those two functions going to get larger? If not, why not just call tegra_{set,clear}_cpu_in_lp2() from tegra_suspend_enter()? Note: I realized that the LP0/LP1 functions might be larger, and feel free to make them separate functions when they're implemented, but if those two functions specifically are always going to be a single line, then there's little point in separating them out, is there? > +void __init tegra_init_suspend(void) ... > #endif ... but this function is only implemented inside an ifdef ... > diff --git a/arch/arm/mach-tegra/pm.h b/arch/arm/mach-tegra/pm.h > +void tegra_init_suspend(void); ... and no dummy inline is provided if the ifdef isn't defined. So, turning off whatever that ifdef is would cause a build error. > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c > +unsigned long tegra_pmc_get_cpu_timer(void) ... > +unsigned long tegra_pmc_get_cpu_off_timer(void) I think you want to make those return u32, since the values they return should be u32 to match DT cell type. > +void tegra_pmc_pm_set(enum tegra_suspend_mode mode) > +{ > + u32 reg; > + > + reg = tegra_pmc_readl(PMC_CTRL); > + reg |= TEGRA_POWER_CPU_PWRREQ_OE; > + reg &= ~TEGRA_POWER_EFFECT_LP0; > + > + tegra_pmc_writel(reg, PMC_CTRL); > +} The "mode" parameter doesn't seem to be used here. One overall comment: tegra_suspend_enter() only supports LP2 so far, but I don't see a check anywhere (e.g. tegra_init_suspend() or tegra_pmc_parse_dt()) which prevents suspend from being initialized if the user requested some other type, or on SoCs where even LP2 isn't supported yet (e.g. Tegra114). -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2013-03-06 at 02:45 +0800, Stephen Warren wrote: > On 03/04/2013 04:40 AM, Joseph Lo wrote: > > Adding suspend to ram support for Tegra platform. There are three suspend > > nit: s/ram/RAM/ > > > mode for Tegra. The difference were below. > > Does this patch work for all 3 upstream Tegras, or just Tegra20 (or 20+30?). > Only for Tegra20 and 30 now. The Tegra114's support need to wait for cpu suspend function first. > > diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c > > > + tegra_init_suspend(); > > That call isn't ifdef'd on anything ... > Will fix. > > diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c > > > +static void tegra_suspend_enter_lp2(void) > > +{ > > + tegra_set_cpu_in_lp2(0); > > +} > > + > > +static void tegra_suspend_exit_lp2(void) > > +{ > > + tegra_clear_cpu_in_lp2(0); > > +} > > Are those two functions going to get larger? If not, why not just call > tegra_{set,clear}_cpu_in_lp2() from tegra_suspend_enter()? > > Note: I realized that the LP0/LP1 functions might be larger, and feel > free to make them separate functions when they're implemented, but if > those two functions specifically are always going to be a single line, > then there's little point in separating them out, is there? > No, just like you said for LP2 suspend it only just need to call tegra_{set,clear}_cpu_in_lp2(). So I will follow your suggestion. Thanks. > > +void __init tegra_init_suspend(void) > ... > > #endif > > ... but this function is only implemented inside an ifdef ... > > > diff --git a/arch/arm/mach-tegra/pm.h b/arch/arm/mach-tegra/pm.h > > > +void tegra_init_suspend(void); > > ... and no dummy inline is provided if the ifdef isn't defined. > > So, turning off whatever that ifdef is would cause a build error. > > > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c > > > +unsigned long tegra_pmc_get_cpu_timer(void) > ... > > +unsigned long tegra_pmc_get_cpu_off_timer(void) > > I think you want to make those return u32, since the values they return > should be u32 to match DT cell type. > Will fix. > > +void tegra_pmc_pm_set(enum tegra_suspend_mode mode) > > +{ > > + u32 reg; > > + > > + reg = tegra_pmc_readl(PMC_CTRL); > > + reg |= TEGRA_POWER_CPU_PWRREQ_OE; > > + reg &= ~TEGRA_POWER_EFFECT_LP0; > > + > > + tegra_pmc_writel(reg, PMC_CTRL); > > +} > > The "mode" parameter doesn't seem to be used here. > > One overall comment: tegra_suspend_enter() only supports LP2 so far, but > I don't see a check anywhere (e.g. tegra_init_suspend() or > tegra_pmc_parse_dt()) which prevents suspend from being initialized if > the user requested some other type, or on SoCs where even LP2 isn't > supported yet (e.g. Tegra114). OK. Will remove now. Thanks, Joseph -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c index bc7268a..fd67efa 100644 --- a/arch/arm/mach-tegra/common.c +++ b/arch/arm/mach-tegra/common.c @@ -65,6 +65,7 @@ void __init tegra_dt_init_irq(void) tegra_init_irq(); irqchip_init(); tegra_legacy_irq_syscore_init(); + tegra_init_suspend(); } #endif diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c index 523604d..334ffdf 100644 --- a/arch/arm/mach-tegra/pm.c +++ b/arch/arm/mach-tegra/pm.c @@ -22,6 +22,7 @@ #include <linux/cpumask.h> #include <linux/delay.h> #include <linux/cpu_pm.h> +#include <linux/suspend.h> #include <linux/clk.h> #include <linux/err.h> #include <linux/clk/tegra.h> @@ -38,6 +39,7 @@ #include "flowctrl.h" #include "fuse.h" #include "sleep.h" +#include "pmc.h" #define TEGRA_POWER_CPU_PWRREQ_OE (1 << 16) /* CPU pwr req enable */ @@ -216,4 +218,77 @@ void tegra_idle_lp2_last(u32 cpu_on_time, u32 cpu_off_time) restore_cpu_complex(); cpu_cluster_pm_exit(); } + +static void tegra_suspend_enter_lp2(void) +{ + tegra_set_cpu_in_lp2(0); +} + +static void tegra_suspend_exit_lp2(void) +{ + tegra_clear_cpu_in_lp2(0); +} + +static const char *lp_state[TEGRA_MAX_SUSPEND_MODE] = { + [TEGRA_SUSPEND_NONE] = "none", + [TEGRA_SUSPEND_LP2] = "LP2", + [TEGRA_SUSPEND_LP1] = "LP1", + [TEGRA_SUSPEND_LP0] = "LP0", +}; + +static int __cpuinit tegra_suspend_enter(suspend_state_t state) +{ + enum tegra_suspend_mode mode = tegra_pmc_get_suspend_mode(); + + if (WARN_ON(mode < TEGRA_SUSPEND_NONE || + mode >= TEGRA_MAX_SUSPEND_MODE)) + return -EINVAL; + + pr_info("Entering suspend state %s\n", lp_state[mode]); + + tegra_pmc_pm_set(mode); + set_power_timers(tegra_pmc_get_cpu_timer(), + tegra_pmc_get_cpu_off_timer()); + + local_fiq_disable(); + + suspend_cpu_complex(); + switch (mode) { + case TEGRA_SUSPEND_LP2: + tegra_suspend_enter_lp2(); + break; + default: + break; + } + + cpu_suspend(PHYS_OFFSET - PAGE_OFFSET, &tegra_sleep_cpu); + + switch (mode) { + case TEGRA_SUSPEND_LP2: + tegra_suspend_exit_lp2(); + break; + default: + break; + } + restore_cpu_complex(); + + local_fiq_enable(); + + return 0; +} + +static const struct platform_suspend_ops tegra_suspend_ops = { + .valid = suspend_valid_only_mem, + .enter = tegra_suspend_enter, +}; + +void __init tegra_init_suspend(void) +{ + if (tegra_pmc_get_suspend_mode() == TEGRA_SUSPEND_NONE) + return; + + tegra_pmc_suspend_init(); + + suspend_set_ops(&tegra_suspend_ops); +} #endif diff --git a/arch/arm/mach-tegra/pm.h b/arch/arm/mach-tegra/pm.h index 787335c..7eced59 100644 --- a/arch/arm/mach-tegra/pm.h +++ b/arch/arm/mach-tegra/pm.h @@ -32,4 +32,6 @@ bool tegra_set_cpu_in_lp2(int phy_cpu_id); void tegra_idle_lp2_last(u32 cpu_on_time, u32 cpu_off_time); extern void (*tegra_tear_down_cpu)(void); +void tegra_init_suspend(void); + #endif /* _MACH_TEGRA_PM_H_ */ diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c index f30c660..94838d0 100644 --- a/arch/arm/mach-tegra/pmc.c +++ b/arch/arm/mach-tegra/pmc.c @@ -20,7 +20,13 @@ #include <linux/of.h> #include <linux/of_address.h> +#include "fuse.h" #include "pmc.h" +#include "sleep.h" + +#define TEGRA_POWER_EFFECT_LP0 (1 << 14) /* LP0 when CPU pwr gated */ +#define TEGRA_POWER_CPU_PWRREQ_POLARITY (1 << 15) /* CPU pwr req polarity */ +#define TEGRA_POWER_CPU_PWRREQ_OE (1 << 16) /* CPU pwr req enable */ #define PMC_CTRL 0x0 #define PMC_CTRL_INTR_LOW (1 << 17) @@ -151,6 +157,45 @@ int tegra_pmc_cpu_remove_clamping(int cpuid) return tegra_pmc_powergate_remove_clamping(id); } +#ifdef CONFIG_PM_SLEEP +enum tegra_suspend_mode tegra_pmc_get_suspend_mode(void) +{ + return pmc_pm_data.suspend_mode; +} + +unsigned long tegra_pmc_get_cpu_timer(void) +{ + return pmc_pm_data.cpu_good_time; +} + +unsigned long tegra_pmc_get_cpu_off_timer(void) +{ + return pmc_pm_data.cpu_off_time; +} + +void tegra_pmc_pm_set(enum tegra_suspend_mode mode) +{ + u32 reg; + + reg = tegra_pmc_readl(PMC_CTRL); + reg |= TEGRA_POWER_CPU_PWRREQ_OE; + reg &= ~TEGRA_POWER_EFFECT_LP0; + + tegra_pmc_writel(reg, PMC_CTRL); +} + +void tegra_pmc_suspend_init(void) +{ + u32 reg; + + /* Always enable CPU power request; just normal polarity is supported */ + reg = tegra_pmc_readl(PMC_CTRL); + BUG_ON(reg & TEGRA_POWER_CPU_PWRREQ_POLARITY); + reg |= TEGRA_POWER_CPU_PWRREQ_OE; + tegra_pmc_writel(reg, PMC_CTRL); +} +#endif + static const struct of_device_id matches[] __initconst = { { .compatible = "nvidia,tegra114-pmc" }, { .compatible = "nvidia,tegra30-pmc" }, diff --git a/arch/arm/mach-tegra/pmc.h b/arch/arm/mach-tegra/pmc.h index 1c4b4de..4452d72 100644 --- a/arch/arm/mach-tegra/pmc.h +++ b/arch/arm/mach-tegra/pmc.h @@ -26,6 +26,14 @@ enum tegra_suspend_mode { TEGRA_MAX_SUSPEND_MODE, }; +#ifdef CONFIG_PM_SLEEP +enum tegra_suspend_mode tegra_pmc_get_suspend_mode(void); +unsigned long tegra_pmc_get_cpu_timer(void); +unsigned long tegra_pmc_get_cpu_off_timer(void); +void tegra_pmc_pm_set(enum tegra_suspend_mode mode); +void tegra_pmc_suspend_init(void); +#endif + bool tegra_pmc_cpu_is_powered(int cpuid); int tegra_pmc_cpu_power_on(int cpuid); int tegra_pmc_cpu_remove_clamping(int cpuid);
Adding suspend to ram support for Tegra platform. There are three suspend mode for Tegra. The difference were below. * LP2: CPU voltage off * LP1: CPU voltage off, DRAM in self-refresh * LP0: CPU + Core voltage off, DRAM in self-refresh After this patch, the LP2 suspend mode will be supported. Signed-off-by: Joseph Lo <josephl@nvidia.com> --- arch/arm/mach-tegra/common.c | 1 + arch/arm/mach-tegra/pm.c | 75 ++++++++++++++++++++++++++++++++++++++++++++ arch/arm/mach-tegra/pm.h | 2 ++ arch/arm/mach-tegra/pmc.c | 45 ++++++++++++++++++++++++++ arch/arm/mach-tegra/pmc.h | 8 +++++ 5 files changed, 131 insertions(+)