Patchwork [20/24] rtc: rtc-sh: use module_platform_driver_probe()

login
register
mail settings
Submitter Jingoo Han
Date March 4, 2013, 8:05 a.m.
Message ID <014d01ce18af$0c473620$24d5a260$%han@samsung.com>
Download mbox | patch
Permalink /patch/224629/
State New
Headers show

Comments

Jingoo Han - March 4, 2013, 8:05 a.m.
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-sh.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
Paul Mundt - March 5, 2013, 7:23 a.m.
On Mon, Mar 04, 2013 at 05:05:34PM +0900, Jingoo Han wrote:
> This patch uses module_platform_driver_probe() macro which makes
> the code smaller and simpler.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Not sure I see the point, but:

Acked-by: Paul Mundt <lethal@linux-sh.org>

Patch

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index e55a763..5f47085 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -820,18 +820,7 @@  static struct platform_driver sh_rtc_platform_driver = {
 	.remove		= __exit_p(sh_rtc_remove),
 };
 
-static int __init sh_rtc_init(void)
-{
-	return platform_driver_probe(&sh_rtc_platform_driver, sh_rtc_probe);
-}
-
-static void __exit sh_rtc_exit(void)
-{
-	platform_driver_unregister(&sh_rtc_platform_driver);
-}
-
-module_init(sh_rtc_init);
-module_exit(sh_rtc_exit);
+module_platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);
 
 MODULE_DESCRIPTION("SuperH on-chip RTC driver");
 MODULE_VERSION(DRV_VERSION);