Patchwork [17/24] rtc: rtc-ps3: use module_platform_driver_probe()

login
register
mail settings
Submitter Jingoo Han
Date March 4, 2013, 8:04 a.m.
Message ID <014a01ce18ae$e294c5e0$a7be51a0$%han@samsung.com>
Download mbox | patch
Permalink /patch/224626/
State New
Headers show

Comments

Jingoo Han - March 4, 2013, 8:04 a.m.
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-ps3.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
Geert Uytterhoeven - March 4, 2013, 9:56 p.m.
On Mon, Mar 4, 2013 at 9:04 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> This patch uses module_platform_driver_probe() macro which makes
> the code smaller and simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> ---
>  drivers/rtc/rtc-ps3.c |   13 +------------
>  1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ps3.c b/drivers/rtc/rtc-ps3.c
> index 968133c..846722d 100644
> --- a/drivers/rtc/rtc-ps3.c
> +++ b/drivers/rtc/rtc-ps3.c
> @@ -85,18 +85,7 @@ static struct platform_driver ps3_rtc_driver = {
>         .remove = __exit_p(ps3_rtc_remove),
>  };
>
> -static int __init ps3_rtc_init(void)
> -{
> -       return platform_driver_probe(&ps3_rtc_driver, ps3_rtc_probe);
> -}
> -
> -static void __exit ps3_rtc_fini(void)
> -{
> -       platform_driver_unregister(&ps3_rtc_driver);
> -}
> -
> -module_init(ps3_rtc_init);
> -module_exit(ps3_rtc_fini);
> +module_platform_driver_probe(ps3_rtc_driver, ps3_rtc_probe);
>
>  MODULE_AUTHOR("Sony Corporation");
>  MODULE_LICENSE("GPL");

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch

diff --git a/drivers/rtc/rtc-ps3.c b/drivers/rtc/rtc-ps3.c
index 968133c..846722d 100644
--- a/drivers/rtc/rtc-ps3.c
+++ b/drivers/rtc/rtc-ps3.c
@@ -85,18 +85,7 @@  static struct platform_driver ps3_rtc_driver = {
 	.remove = __exit_p(ps3_rtc_remove),
 };
 
-static int __init ps3_rtc_init(void)
-{
-	return platform_driver_probe(&ps3_rtc_driver, ps3_rtc_probe);
-}
-
-static void __exit ps3_rtc_fini(void)
-{
-	platform_driver_unregister(&ps3_rtc_driver);
-}
-
-module_init(ps3_rtc_init);
-module_exit(ps3_rtc_fini);
+module_platform_driver_probe(ps3_rtc_driver, ps3_rtc_probe);
 
 MODULE_AUTHOR("Sony Corporation");
 MODULE_LICENSE("GPL");