Patchwork [12/24] rtc: rtc-msm6242: use module_platform_driver_probe()

login
register
mail settings
Submitter Jingoo Han
Date March 4, 2013, 8:02 a.m.
Message ID <014501ce18ae$96f88a90$c4e99fb0$%han@samsung.com>
Download mbox | patch
Permalink /patch/224621/
State New
Headers show

Comments

Jingoo Han - March 4, 2013, 8:02 a.m.
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-msm6242.c |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)
Geert Uytterhoeven - March 4, 2013, 9:55 p.m.
On Mon, Mar 4, 2013 at 9:02 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> This patch uses module_platform_driver_probe() macro which makes
> the code smaller and simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> ---
>  drivers/rtc/rtc-msm6242.c |   13 +------------
>  1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/rtc/rtc-msm6242.c b/drivers/rtc/rtc-msm6242.c
> index fcb113c..3ac1e8e 100644
> --- a/drivers/rtc/rtc-msm6242.c
> +++ b/drivers/rtc/rtc-msm6242.c
> @@ -252,18 +252,7 @@ static struct platform_driver msm6242_rtc_driver = {
>         .remove = __exit_p(msm6242_rtc_remove),
>  };
>
> -static int __init msm6242_rtc_init(void)
> -{
> -       return platform_driver_probe(&msm6242_rtc_driver, msm6242_rtc_probe);
> -}
> -
> -static void __exit msm6242_rtc_fini(void)
> -{
> -       platform_driver_unregister(&msm6242_rtc_driver);
> -}
> -
> -module_init(msm6242_rtc_init);
> -module_exit(msm6242_rtc_fini);
> +module_platform_driver_probe(msm6242_rtc_driver, msm6242_rtc_probe);
>
>  MODULE_AUTHOR("Geert Uytterhoeven <geert@linux-m68k.org>");
>  MODULE_LICENSE("GPL");

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch

diff --git a/drivers/rtc/rtc-msm6242.c b/drivers/rtc/rtc-msm6242.c
index fcb113c..3ac1e8e 100644
--- a/drivers/rtc/rtc-msm6242.c
+++ b/drivers/rtc/rtc-msm6242.c
@@ -252,18 +252,7 @@  static struct platform_driver msm6242_rtc_driver = {
 	.remove	= __exit_p(msm6242_rtc_remove),
 };
 
-static int __init msm6242_rtc_init(void)
-{
-	return platform_driver_probe(&msm6242_rtc_driver, msm6242_rtc_probe);
-}
-
-static void __exit msm6242_rtc_fini(void)
-{
-	platform_driver_unregister(&msm6242_rtc_driver);
-}
-
-module_init(msm6242_rtc_init);
-module_exit(msm6242_rtc_fini);
+module_platform_driver_probe(msm6242_rtc_driver, msm6242_rtc_probe);
 
 MODULE_AUTHOR("Geert Uytterhoeven <geert@linux-m68k.org>");
 MODULE_LICENSE("GPL");