| Message ID | 1362353404-27034-1-git-send-email-claudiu.ghioc@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 2013-03-04 at 01:30 +0200, Claudiu Ghioc wrote: > Removed the following sparse warning: > * net/core/filter.c:48:6: warning: symbol > 'bpf_internal_load_pointer_neg_helper' was > not declared. Should it be static? > > Signed-off-by: Claudiu Ghioc <claudiu.ghioc@gmail.com> > --- > net/core/filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 2e20b55..f6c907c 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -45,7 +45,7 @@ > * > * Exported for the bpf jit load helper. > */ > -void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size) > +static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size) > { > u8 *ptr = NULL; > Hmm, have you read the comment ? Also : -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/filter.c b/net/core/filter.c index 2e20b55..f6c907c 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -45,7 +45,7 @@ * * Exported for the bpf jit load helper. */ -void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size) +static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size) { u8 *ptr = NULL;
Removed the following sparse warning: * net/core/filter.c:48:6: warning: symbol 'bpf_internal_load_pointer_neg_helper' was not declared. Should it be static? Signed-off-by: Claudiu Ghioc <claudiu.ghioc@gmail.com> --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)