From patchwork Sun Mar 3 18:42:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mikael Morin X-Patchwork-Id: 224563 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D102C2C030B for ; Mon, 4 Mar 2013 05:42:25 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362940947; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=WlSfAlh NxTKFgooY+97kXS5hZFs=; b=amhjttjp/ER/kR/cd+Vr7GsFFtF189voAaQ7pU/ 5fAZI7slMVW+n+9SUgKbcvImkVmFIUcYwdP7AG4QNeNJqsT7kUAqLbARDO3ZZ3Hr MuAVFDgA0T4k37pCfPLGANGrkRQxahavg5QJstQlyKABB/GzFBUBo0QSd+gfAI95 Xt/8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:X-SFR-UUID:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=LVbkQ0foz5oXBfsPsk5+0bkYhcxIReTmeAFOfvYpXT90VNxeXQerf2AxgJqTzV t5CDR9RtdryZYJWpI1KNbdDPkaQx8c9Vob+YxTGevbYKThqxvPNKa6xgWSUKoMrP 5KBfK4COE0bOasd8s/qR1kXKNqncDkc9qUWCm+43756gs=; Received: (qmail 28565 invoked by alias); 3 Mar 2013 18:42:19 -0000 Received: (qmail 28548 invoked by uid 22791); 3 Mar 2013 18:42:18 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp24.services.sfr.fr (HELO smtp24.services.sfr.fr) (93.17.128.82) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Mar 2013 18:42:11 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2407.sfr.fr (SMTP Server) with ESMTP id C384470000B7; Sun, 3 Mar 2013 19:42:09 +0100 (CET) Received: from [192.168.1.58] (95.183.72.86.rev.sfr.net [86.72.183.95]) by msfrf2407.sfr.fr (SMTP Server) with ESMTP id 6626470000B3; Sun, 3 Mar 2013 19:42:09 +0100 (CET) X-SFR-UUID: 20130303184209418.6626470000B3@msfrf2407.sfr.fr Message-ID: <5133997B.5030302@sfr.fr> Date: Sun, 03 Mar 2013 19:42:03 +0100 From: Mikael Morin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130127 Thunderbird/17.0.2 MIME-Version: 1.0 To: gfortran , gcc-patches Subject: [Patch, fortran] PR56477 ICE on pointer assignment checking X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, I'm testing the attached patch which fixes the PR56477 test case. Will commit as obvious tonight. Mikael 2013-03-03 Mikael Morin PR fortran/56477 * expr.c (gfc_check_pointer_assign): Avoid NULL pointer dereference. 2013-03-03 Mikael Morin PR fortran/56477 * gfortran.dg/pointer_check_13.f90: New test. Index: fortran/expr.c =================================================================== --- fortran/expr.c (révision 196416) +++ fortran/expr.c (copie de travail) @@ -3732,7 +3732,7 @@ gfc_check_pointer_assign (gfc_expr *lvalue, gfc_ex && rvalue->symtree->n.sym->ns->proc_name->attr.flavor != FL_PROCEDURE && rvalue->symtree->n.sym->ns->proc_name->attr.flavor != FL_PROGRAM) for (ns = rvalue->symtree->n.sym->ns; - ns->proc_name && ns->proc_name->attr.flavor != FL_PROCEDURE; + ns && ns->proc_name && ns->proc_name->attr.flavor != FL_PROCEDURE; ns = ns->parent) if (ns->parent == lvalue->symtree->n.sym->ns) warn = true;