Patchwork configure: require spice-protocol >= 0.12.3

login
register
mail settings
Submitter Alon Levy
Date March 3, 2013, 10:04 a.m.
Message ID <1362305055-24079-1-git-send-email-alon@pobox.com>
Download mbox | patch
Permalink /patch/224560/
State New
Headers show

Comments

Alon Levy - March 3, 2013, 10:04 a.m.
Required since v1.4.0-rc0

For SPICE_PORT_EVENT_BREAK used by spice-qemu-char.c since:

commit 5a49d3e9a799b7e1bf87da7ae7f2a719e01da319
Author: Marc-André Lureau <marcandre.lureau@gmail.com>
Date:   Wed Dec 5 16:15:34 2012 +0100

    spice-qemu-char: add spiceport chardev

Signed-off-by: Alon Levy <alon@pobox.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Doug Goldstein - March 3, 2013, 7:45 p.m.
On Sun, Mar 3, 2013 at 4:04 AM, Alon Levy <alon@pobox.com> wrote:
> Required since v1.4.0-rc0
>
> For SPICE_PORT_EVENT_BREAK used by spice-qemu-char.c since:
>
> commit 5a49d3e9a799b7e1bf87da7ae7f2a719e01da319
> Author: Marc-André Lureau <marcandre.lureau@gmail.com>
> Date:   Wed Dec 5 16:15:34 2012 +0100
>
>     spice-qemu-char: add spiceport chardev
>
> Signed-off-by: Alon Levy <alon@pobox.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 19738ac..82b7b54 100755
> --- a/configure
> +++ b/configure
> @@ -2867,7 +2867,7 @@ EOF
>    spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
>    spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
>    if $pkg_config --atleast-version=0.12.0 spice-server >/dev/null 2>&1 && \
> -     $pkg_config --atleast-version=0.12.2 spice-protocol > /dev/null 2>&1 && \
> +     $pkg_config --atleast-version=0.12.3 spice-protocol > /dev/null 2>&1 && \
>       compile_prog "$spice_cflags" "$spice_libs" ; then
>      spice="yes"
>      libs_softmmu="$libs_softmmu $spice_libs"
> --
> 1.8.1.2
>
>

I can confirm this issue and that this is the fix. This change is
queued in my 1.4 stable series as well.

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

Patch

diff --git a/configure b/configure
index 19738ac..82b7b54 100755
--- a/configure
+++ b/configure
@@ -2867,7 +2867,7 @@  EOF
   spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
   spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
   if $pkg_config --atleast-version=0.12.0 spice-server >/dev/null 2>&1 && \
-     $pkg_config --atleast-version=0.12.2 spice-protocol > /dev/null 2>&1 && \
+     $pkg_config --atleast-version=0.12.3 spice-protocol > /dev/null 2>&1 && \
      compile_prog "$spice_cflags" "$spice_libs" ; then
     spice="yes"
     libs_softmmu="$libs_softmmu $spice_libs"