Patchwork [1/1] Added lcms2 package

login
register
mail settings
Submitter Olivier Schonken
Date March 2, 2013, 6:47 p.m.
Message ID <1362250047-26425-1-git-send-email-olivier.schonken@gmail.com>
Download mbox | patch
Permalink /patch/224521/
State Changes Requested
Headers show

Comments

Olivier Schonken - March 2, 2013, 6:47 p.m.
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.

Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
---
 package/Config.in       |    1 +
 package/lcms2/Config.in |   12 ++++++++++++
 package/lcms2/lcms2.mk  |   23 +++++++++++++++++++++++
 3 files changed, 36 insertions(+)
 create mode 100644 package/lcms2/Config.in
 create mode 100644 package/lcms2/lcms2.mk
Thomas Petazzoni - March 3, 2013, 4:11 p.m.
Dear Olivier Schonken,

Thanks for your contribution! A few comments below.

On Sat,  2 Mar 2013 20:47:27 +0200, Olivier Schonken wrote:
> Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.

This should be wrapped at ~80 columns.


> diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
> new file mode 100644
> index 0000000..be14554
> --- /dev/null
> +++ b/package/lcms2/lcms2.mk
> @@ -0,0 +1,23 @@
> +#############################################################
> +#
> +# lcms2-2.4.tar.gz

Should be just "lcms2"

> +#
> +#############################################################
> +LCMS2_VERSION = 2.4

One line between the comment header and the first variable line.

> +LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/

This should use http://downloads.sourceforge.net instead, see other
packages. downloads.sourceforge.net automatically redirects to a
working SourceForge mirror. 

> +LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz

This is not needed, that's the default.

> +LCMS2_INSTALL_STAGING = YES
> +LCMS2_LIBTOOL_PATCH = YES 

This is not needed, that's the default (for LIBTOOL_PATCH).

> +LCMS2_AUTORECONF = NO

This is not needed, that's the default.

> +LCMS2_CONF_OPT =           

Not needed.

> +
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +             LCMS2_CONF_OPT += --disable-shared 
> +else
> +             LCMS2_CONF_OPT += --enable-shared 
> +endif

Not needed, that's already done by the common autotools infrastructure,
see:
http://git.buildroot.net/buildroot/tree/package/pkg-autotools.mk#n112,
where SHARED_STATIC_LIBS_OPTS is defined at
http://git.buildroot.net/buildroot/tree/package/Makefile.in#n321.

Best regards,

Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index 8a02506..ce9c6be 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -421,6 +421,7 @@  source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
 source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
+source "package/lcms2/Config.in"
 source "package/libart/Config.in"
 source "package/libdmtx/Config.in"
 source "package/libdrm/Config.in"
diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in
new file mode 100644
index 0000000..d648d24
--- /dev/null
+++ b/package/lcms2/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_LCMS2
+	bool "lcms2"
+	help
+	  Little Color Management Software
+	  Little CMS intends to be an OPEN SOURCE small-footprint color 
+	  management engine, with special focus on accuracy and performance. 
+	  It uses the International Color Consortium standard (ICC), which is
+	  the modern standard when regarding to color management.
+
+	  http://www.littlecms.com/
+
+
diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk
new file mode 100644
index 0000000..be14554
--- /dev/null
+++ b/package/lcms2/lcms2.mk
@@ -0,0 +1,23 @@ 
+#############################################################
+#
+# lcms2-2.4.tar.gz
+#
+#############################################################
+LCMS2_VERSION = 2.4
+LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/
+LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz
+LCMS2_INSTALL_STAGING = YES
+LCMS2_LIBTOOL_PATCH = YES 
+LCMS2_AUTORECONF = NO
+LCMS2_CONF_OPT =           
+
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+             LCMS2_CONF_OPT += --disable-shared 
+else
+             LCMS2_CONF_OPT += --enable-shared 
+endif
+
+LCMS2_DEPENDENCIES = host-lcms2
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))