Patchwork qemu-ga: make guest-sync-delimited available during fsfreeze

login
register
mail settings
Submitter Michael Roth
Date March 1, 2013, 5:53 p.m.
Message ID <1362160421-20637-1-git-send-email-mdroth@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/224425/
State New
Headers show

Comments

Michael Roth - March 1, 2013, 5:53 p.m.
We currently maintain a whitelist of commands that are safe during
fsfreeze. During fsfreeze, we disable all commands that aren't part of
that whitelist.

guest-sync-delimited meets the criteria for being whitelisted, and is
also required for qemu-ga clients that rely on guest-sync-delimited for
re-syncing the channel after a timeout.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-stable@nongnu.org
---
 qga/main.c |    1 +
 1 file changed, 1 insertion(+)
Eric Blake - March 1, 2013, 6:10 p.m.
On 03/01/2013 10:53 AM, Michael Roth wrote:
> We currently maintain a whitelist of commands that are safe during
> fsfreeze. During fsfreeze, we disable all commands that aren't part of
> that whitelist.
> 
> guest-sync-delimited meets the criteria for being whitelisted, and is
> also required for qemu-ga clients that rely on guest-sync-delimited for
> re-syncing the channel after a timeout.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org
> ---
>  qga/main.c |    1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qga/main.c b/qga/main.c
> index db281a5..ad75171 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
>      "guest-ping",
>      "guest-info",
>      "guest-sync",
> +    "guest-sync-delimited",
>      "guest-fsfreeze-status",
>      "guest-fsfreeze-thaw",
>      NULL
>
Michael Roth - March 4, 2013, 7:28 p.m.
On Fri, Mar 01, 2013 at 11:53:40AM -0600, Michael Roth wrote:
> We currently maintain a whitelist of commands that are safe during
> fsfreeze. During fsfreeze, we disable all commands that aren't part of
> that whitelist.
> 
> guest-sync-delimited meets the criteria for being whitelisted, and is
> also required for qemu-ga clients that rely on guest-sync-delimited for
> re-syncing the channel after a timeout.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org

Thanks, applied to qga branch.

> ---
>  qga/main.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qga/main.c b/qga/main.c
> index db281a5..ad75171 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
>      "guest-ping",
>      "guest-info",
>      "guest-sync",
> +    "guest-sync-delimited",
>      "guest-fsfreeze-status",
>      "guest-fsfreeze-thaw",
>      NULL
> -- 
> 1.7.9.5
>

Patch

diff --git a/qga/main.c b/qga/main.c
index db281a5..ad75171 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -85,6 +85,7 @@  static const char *ga_freeze_whitelist[] = {
     "guest-ping",
     "guest-info",
     "guest-sync",
+    "guest-sync-delimited",
     "guest-fsfreeze-status",
     "guest-fsfreeze-thaw",
     NULL