From patchwork Fri Mar 1 17:21:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Feiner X-Patchwork-Id: 224417 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 38AF62C02FA for ; Sat, 2 Mar 2013 04:21:53 +1100 (EST) Received: from localhost ([::1]:44180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBTeZ-0007zz-55 for incoming@patchwork.ozlabs.org; Fri, 01 Mar 2013 12:21:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBTeK-0007zg-AX for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBTeJ-0001RS-38 for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:36 -0500 Received: from mail-ie0-x22d.google.com ([2607:f8b0:4001:c03::22d]:46407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBTeI-0001RI-V3 for qemu-devel@nongnu.org; Fri, 01 Mar 2013 12:21:35 -0500 Received: by mail-ie0-f173.google.com with SMTP id 9so3834052iec.18 for ; Fri, 01 Mar 2013 09:21:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=OTQzNnzwNXJKMWRnMyv0j+zMLLTZrN3lwWxrzjUPYdo=; b=YSEoNrPXIetFO/XAwkeO8NlddOhR62j0+WfEBkhMlt68NoomOjyrCPbRq5GRTKmDdS LZWd7OUUUkLRxeW+N+jRiZlvR5+5MrTlLIOQIfYFOgTwKy/zzPs6QPwgTv/7rHWsnV/L Khl4inQBwzuJ58sK851qpf/wwQGB7yp5lHliq/upWDMmalbo7uIGkKp5ojufVHa11Rak TCSU8K+2nI9yPLLNNR+i0hrqSy3eparM1qps0HImSdQiySOAAAVXt8W5rpwGNJ47G3a4 ZM0N4a0LeSkyymE2JcEQyy90esR/VuQUrwIiAIrkL0dSrvYvjJiw15FXNA8/ISkB9UoF vGHg== X-Received: by 10.50.88.165 with SMTP id bh5mr13372355igb.71.1362158493745; Fri, 01 Mar 2013 09:21:33 -0800 (PST) Received: from jam.gridcentric.ca ([206.223.182.18]) by mx.google.com with ESMTPS id vb15sm10759216igb.9.2013.03.01.09.21.32 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 01 Mar 2013 09:21:33 -0800 (PST) From: peter@gridcentric.ca To: qemu-devel@nongnu.org, aliguori@us.ibm.com Date: Fri, 1 Mar 2013 12:21:33 -0500 Message-Id: <1362158493-11907-1-git-send-email-peter@gridcentric.ca> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <876237ebst.fsf@codemonkey.ws> References: <876237ebst.fsf@codemonkey.ws> X-Gm-Message-State: ALoCoQneYWbTFeAqCRhM9FO3Q77e361vYd8OyQVjPWQf8eci81sNzQDlDy+g/xMeHomukU3Ne85/ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::22d Cc: andreslc@gridcentric.ca, peter@gridcentric.ca Subject: [Qemu-devel] [PATCH v2] exec: make -mem-path filenames deterministic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Feiner Adds ramblocks' names to their backing files when using -mem-path. Eases introspection and debugging. Signed-off-by: Peter Feiner --- On Tue, Jan 8, 2013 at 2:04 PM, Anthony Liguori wrote: > > Yes, please submit the oneliner. Here it is :) The commit should probably be called "exec: add ramblocks' names to -mem-path files" since the paths aren't deterministic. v1 -> v2: Just add ramblock name to mkstemp template. Thanks, Peter exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index a41bcb8..16a5452 100644 --- a/exec.c +++ b/exec.c @@ -865,7 +865,8 @@ static void *file_ram_alloc(RAMBlock *block, return NULL; } - filename = g_strdup_printf("%s/qemu_back_mem.XXXXXX", path); + filename = g_strdup_printf("%s/qemu_back_mem.%s.XXXXXX", path, + block->mr->name); fd = mkstemp(filename); if (fd < 0) {