Patchwork [3/3] opkg: Add gnupg signature checking support.

login
register
mail settings
Submitter Philipp Claves
Date March 1, 2013, 1:38 p.m.
Message ID <1362145109-32509-3-git-send-email-claves@budelmann-elektronik.com>
Download mbox | patch
Permalink /patch/224339/
State Accepted
Headers show

Comments

Philipp Claves - March 1, 2013, 1:38 p.m.
Signed-off-by: Philipp Claves <claves@budelmann-elektronik.com>
---
 package/opkg/Config.in | 9 +++++++++
 package/opkg/opkg.mk   | 9 ++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)
Philipp Claves - April 8, 2013, 10:26 a.m.
Hello,

Any status update on merging this patchset?

Regards,
Philipp Claves

On Freitag, March 1st 2013, 14:38:29 Philipp Claves wrote:
> Signed-off-by: Philipp Claves <claves@budelmann-elektronik.com>
> ---
>  package/opkg/Config.in | 9 +++++++++
>  package/opkg/opkg.mk   | 9 ++++++++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/package/opkg/Config.in b/package/opkg/Config.in
> index eb997a7..b8b4a13 100644
> --- a/package/opkg/Config.in
> +++ b/package/opkg/Config.in
> @@ -11,3 +11,12 @@ config BR2_PACKAGE_OPKG
> 
>  	  http://code.google.com/p/opkg/
> 
> +if BR2_PACKAGE_OPKG
> +
> +config BR2_PACKAGE_OPKG_GPG_SIGN
> +	bool "opkg-gnupg-support"
> +	select BR2_PACKAGE_LIBGPGME
> +	help
> +	  Enable opkg package signature checking support using gnupg/libgpgme.
> +
> +endif
> diff --git a/package/opkg/opkg.mk b/package/opkg/opkg.mk
> index 9932d3f..3c53299 100644
> --- a/package/opkg/opkg.mk
> +++ b/package/opkg/opkg.mk
> @@ -9,7 +9,7 @@ OPKG_SOURCE = opkg-$(OPKG_VERSION).tar.gz
>  OPKG_SITE = http://opkg.googlecode.com/svn/trunk/
>  OPKG_SITE_METHOD = svn
>  OPKG_INSTALL_STAGING = YES
> -OPKG_CONF_OPT = --disable-curl --disable-gpg
> +OPKG_CONF_OPT = --disable-curl
>  OPKG_AUTORECONF = YES
>  # Uses PKG_CHECK_MODULES() in configure.ac
>  OPKG_DEPENDENCIES = host-pkgconf
> @@ -19,6 +19,13 @@ define OPKG_CREATE_LOCKDIR
>  	mkdir -p $(TARGET_DIR)/usr/lib/opkg
>  endef
> 
> +ifeq ($(BR2_PACKAGE_OPKG_GPG_SIGN),y)
> +	OPKG_CONF_OPT += --enable-gpg
> +	OPKG_DEPENDENCIES += libgpgme
> +else
> +	OPKG_CONF_OPT += --disable-gpg
> +endif
> +
>  OPKG_POST_INSTALL_TARGET_HOOKS += OPKG_CREATE_LOCKDIR
> 
>  $(eval $(autotools-package))
Arnout Vandecappelle - April 9, 2013, 4:03 p.m.
On 08/04/13 12:26, Philipp Claves wrote:
> Any status update on merging this patchset?

  Thomas sent comments about your patches and we assumed you would that 
re-send them taking into account the review feedback. If you are not 
planning to send updated patches, please tell us. Then somebody else may 
pick up the patches (but don't count on it).

  Regards,
  Arnout
Thomas Petazzoni - April 10, 2013, 5:40 p.m.
Dear Arnout Vandecappelle,

On Tue, 09 Apr 2013 18:03:45 +0200, Arnout Vandecappelle wrote:
> On 08/04/13 12:26, Philipp Claves wrote:
> > Any status update on merging this patchset?
> 
>   Thomas sent comments about your patches and we assumed you would that 
> re-send them taking into account the review feedback. If you are not 
> planning to send updated patches, please tell us. Then somebody else may 
> pick up the patches (but don't count on it).

I sent some comments on March, 1st at 11 AM, and at 2 PM on the same
day, Philipp resubmitted updated versions of his patches. I haven't
reviewed the latest version from Philipp. So I think that the ball is
on our side (Buildroot reviewers) and not on Philipp side.

Thomas
Philipp Claves - April 26, 2013, 11:41 a.m.
Knock Knock

Am Mittwoch, 10. April 2013, 19:40:36 schrieb Thomas Petazzoni:
> Dear Arnout Vandecappelle,
> 
> On Tue, 09 Apr 2013 18:03:45 +0200, Arnout Vandecappelle wrote:
> > On 08/04/13 12:26, Philipp Claves wrote:
> > > Any status update on merging this patchset?
> > > 
> >   Thomas sent comments about your patches and we assumed you would that
> > 
> > re-send them taking into account the review feedback. If you are not
> > planning to send updated patches, please tell us. Then somebody else may
> > pick up the patches (but don't count on it).
> 
> I sent some comments on March, 1st at 11 AM, and at 2 PM on the same
> day, Philipp resubmitted updated versions of his patches. I haven't
> reviewed the latest version from Philipp. So I think that the ball is
> on our side (Buildroot reviewers) and not on Philipp side.
> 
> Thomas

Patch

diff --git a/package/opkg/Config.in b/package/opkg/Config.in
index eb997a7..b8b4a13 100644
--- a/package/opkg/Config.in
+++ b/package/opkg/Config.in
@@ -11,3 +11,12 @@  config BR2_PACKAGE_OPKG
 
 	  http://code.google.com/p/opkg/
 
+if BR2_PACKAGE_OPKG
+
+config BR2_PACKAGE_OPKG_GPG_SIGN
+	bool "opkg-gnupg-support"
+	select BR2_PACKAGE_LIBGPGME
+	help
+	  Enable opkg package signature checking support using gnupg/libgpgme.
+
+endif
diff --git a/package/opkg/opkg.mk b/package/opkg/opkg.mk
index 9932d3f..3c53299 100644
--- a/package/opkg/opkg.mk
+++ b/package/opkg/opkg.mk
@@ -9,7 +9,7 @@  OPKG_SOURCE = opkg-$(OPKG_VERSION).tar.gz
 OPKG_SITE = http://opkg.googlecode.com/svn/trunk/
 OPKG_SITE_METHOD = svn
 OPKG_INSTALL_STAGING = YES
-OPKG_CONF_OPT = --disable-curl --disable-gpg
+OPKG_CONF_OPT = --disable-curl
 OPKG_AUTORECONF = YES
 # Uses PKG_CHECK_MODULES() in configure.ac
 OPKG_DEPENDENCIES = host-pkgconf
@@ -19,6 +19,13 @@  define OPKG_CREATE_LOCKDIR
 	mkdir -p $(TARGET_DIR)/usr/lib/opkg
 endef
 
+ifeq ($(BR2_PACKAGE_OPKG_GPG_SIGN),y)
+	OPKG_CONF_OPT += --enable-gpg
+	OPKG_DEPENDENCIES += libgpgme
+else
+	OPKG_CONF_OPT += --disable-gpg
+endif
+
 OPKG_POST_INSTALL_TARGET_HOOKS += OPKG_CREATE_LOCKDIR
 
 $(eval $(autotools-package))