From patchwork Fri Mar 1 03:55:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 224223 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 8B0942C029C for ; Fri, 1 Mar 2013 14:55:51 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D94E44A051; Fri, 1 Mar 2013 04:55:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FWPm9MLRYtwb; Fri, 1 Mar 2013 04:55:49 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 807944A048; Fri, 1 Mar 2013 04:55:48 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 047F04A047 for ; Fri, 1 Mar 2013 04:55:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FYHFPsHIUcvD for ; Fri, 1 Mar 2013 04:55:42 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oa0-f48.google.com (mail-oa0-f48.google.com [209.85.219.48]) by theia.denx.de (Postfix) with ESMTPS id 835924A048 for ; Fri, 1 Mar 2013 04:55:40 +0100 (CET) Received: by mail-oa0-f48.google.com with SMTP id j1so4967095oag.35 for ; Thu, 28 Feb 2013 19:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=+CXRu3ksidmUmDIWz2g1BZhOJ6d9MX3+AfqouxbARSU=; b=Att3Owl22b/ATMGCr+9LccoVm5F7jsME/CToNRsyXF857wFLvFLo0lKNppTsDwMP9b kbKDgJfEyznKI3mMgje365Py/Wb3tGpb74SVIALkm1j/JI7+xmPYbn7/+UdcX9yIpCwP eH0GfLU7aXHH4tgmQHRgIzt6YoGP4nMScK0KfcjgK3Gmr7tbGtzGRgtjqTFh+/F04Fup u3aXLo5dM2nW25hWfFs0mUbvK/4PNQmsU3LsPOgd8o+AEM8SJOo8KhJqiEmL/wDx5Qki ZZ4XEP1pPle+BRQbPamhUe2QTUsSyaIvATTf4F417GfkGjw+EOZTGPNdRxCy9te/Z/gd /AfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=+CXRu3ksidmUmDIWz2g1BZhOJ6d9MX3+AfqouxbARSU=; b=HL4vQ1CpydS824Tqdttr7Xu2fyA9WDGzlaeHfxz3HvEDUqgIYHQdzBf6zGUMXDBZHX iVWE1/qYslxA94TT1HiugCBMQWivD2yVkqwqkk1pNZjFDkO5ZySJb73lTLLhWILPga/O x2pfQY0Ig+9d5MKIvp8C++IIl7xFUdooA3Ve4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=+CXRu3ksidmUmDIWz2g1BZhOJ6d9MX3+AfqouxbARSU=; b=pszT3e+s75zpdxIWLWjkkFoMJm6V9XnDc5csW/+1zQxENMyZ33hg7xHEmWX11wyQ1j cRFaLThIb5LuJ+gqr4XOuBRuUja5XtXqBPIqaJO0G+OtKEvEPxgO1Y38/9BkQRIyeKZM W4dtWLG0Ckm90Y7GmtQMl2X0Z9TLK1yGrJiBBY6lWDtzTPL7e7Rkxsf9hDwHb429bBXT cgyKYSumDsgQ4LH4vfQakSI1nX122zh0bTXuqub0TCa7iPXAQyOzjJiC/8z14o0J6ya/ AbgiDIjtiQPptpLRfpu6sNC2yWzVyYqUUiz4XhAtYgeHSJxHfKrnWfWHekiw8pC8cti7 65iA== MIME-Version: 1.0 X-Received: by 10.60.170.140 with SMTP id am12mr7209817oec.125.1362110139482; Thu, 28 Feb 2013 19:55:39 -0800 (PST) Received: by 10.182.107.165 with HTTP; Thu, 28 Feb 2013 19:55:39 -0800 (PST) In-Reply-To: References: <20130217205804.9E8232005E0@gemini.denx.de> <20130218225202.GD3722@bill-the-cat> <20130228230019.GD20569@bill-the-cat> Date: Thu, 28 Feb 2013 19:55:39 -0800 X-Google-Sender-Auth: TNLzn0rApTmi4lBpV_Jh15QVza0 Message-ID: From: Simon Glass To: Tom Rini X-Gm-Message-State: ALoCoQm4SESC7NNJDw3JClZmxHA63bGQD2PJFYip7ktvMEP4PxAG6xPWeike98EsZ5fBipRV5eaXfFcA0HOUiHx7ZK+inNLyAg9QlrF8SXNklytkpQtU9siS6QOHCFmwRklPT/weT6Yd9zD94wBNyEcSNdzNg/hEhuDhXBQvca5j51IgLUSBv4H6SrkyfwLvOOyXEmBLhsUB Cc: U-Boot Mailing List , Vadim Bendebury , Duncan Laurie Subject: Re: [U-Boot] Please pull u-boot-x86.git X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Hi Tom, On Thu, Feb 28, 2013 at 4:22 PM, Simon Glass wrote: > Hi Tom, > > On Thu, Feb 28, 2013 at 3:00 PM, Tom Rini wrote: >> On Wed, Feb 27, 2013 at 01:18:23PM -0800, Simon Glass wrote: >> >>> Hi Tom, >>> >>> I have pulled the latest series into a branch in the x86 tree. You can >>> also get it from patchwork. If you are happy with it, please see >>> below. I haven't seen any comments for a few days. >> >> OK, building with ELDK4.2 for a number of ARM boards such as igep0030: >> cmd_mem.c: In function 'do_mem_mtest': >> cmd_mem.c:979: warning: passing argument 1 of 'unmap_sysmem' discards >> qualifiers from pointer target type >> cmd_mem.c:980: warning: passing argument 1 of 'unmap_sysmem' discards >> qualifiers from pointer target type >> > > Strange - there is even an explicit cast,. But mine is gcc 4.4.1 so > may be a bit later. I could just remove those two lines since they are > only there for semantic correctness and compile to nothing anyway. But > I will track down that tool chain and see if I can work out a fix. OK I have repeated this - it seems that the compiler does not like a direct 'cast away' of volatile in a function argument. I have added a work-around, and sent out an updated patch 20. You can either pull this in from patchwork, or I have updated the pull information below. Rather ominously this might mean that I need to start building with multiple tool chains for each architecture. I was rather hoping to avoid that... Thanks for spotting it. Regards, Simon > >> Please fix and re-submit, thanks. The following changes since commit a1eac57a2001ecf86a46f520cd85ef8e9c8b3687: common/env_nand.c: calculate crc only when readenv was OK (2013-02-22 19:59:53 -0600) are available in the git repository at: git://git.denx.de/u-boot-x86.git mem for you to fetch changes up to 218da0f35f4b5e5bf13d3dba6d975d4d5d65516f: hash: Use lower case for hash algorithm names (2013-02-28 19:49:13 -0800) ---------------------------------------------------------------- Allen Martin (1): sandbox: fix compiler warning Simon Glass (21): Tidy up error checking and fix bug in hash command Update print_buffer() to use const sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf sandbox: Change memory commands to use map_physmem Split out the memory tests into separate functions Use common mtest iteration counting Fix mtest indenting Bring mtest putc() into common code Reduce casting in mtest Update set_working_fdt_addr() to use setenv_addr() common: Use new numeric setenv functions fs: Use new numeric setenv functions net: Use new numeric setenv functions image: Use crc header file instead of C prototypes hash: Add a flag to support saving hashes in the environment Roll crc32 into hash infrastructure sandbox: config: Enable hash functions and mtest Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file sandbox: Update mtest to fix crashes sandbox: Allow hash functions to work correctly hash: Use lower case for hash algorithm names Taylor Hutt (1): sandbox: Improve sandbox serial port keyboard interface README | 9 + arch/sandbox/config.mk | 1 + arch/sandbox/cpu/os.c | 8 + arch/sandbox/cpu/start.c | 3 + arch/sandbox/include/asm/io.h | 10 + common/cmd_bootm.c | 11 +- common/cmd_cbfs.c | 4 +- common/cmd_cramfs.c | 4 +- common/cmd_fdos.c | 4 +- common/cmd_fdt.c | 11 +- common/cmd_hash.c | 14 +- common/cmd_jffs2.c | 4 +- common/cmd_load.c | 12 +- common/cmd_mem.c | 809 ++++++++++++++++++++++++++++++++-------------------------------- common/cmd_mtdparts.c | 4 +- common/cmd_nand.c | 12 +- common/cmd_nvedit.c | 11 +- common/cmd_reiser.c | 4 +- common/cmd_setexpr.c | 39 +++- common/cmd_sha1sum.c | 6 +- common/cmd_unzip.c | 4 +- common/cmd_ximg.c | 7 +- common/cmd_zfs.c | 3 +- common/cmd_zip.c | 4 +- common/hash.c | 194 +++++++++++----- common/image.c | 4 +- drivers/net/fm/fm.c | 4 +- drivers/serial/sandbox.c | 44 +++- fs/fs.c | 4 +- fs/ubifs/ubifs.c | 4 +- include/common.h | 29 ++- include/configs/sandbox.h | 9 +- include/hash.h | 13 +- include/os.h | 10 + include/u-boot/crc.h | 11 + lib/crc32.c | 9 + lib/display_options.c | 3 +- net/net.c | 8 +- 38 files changed, 761 insertions(+), 583 deletions(-)