From patchwork Thu Feb 28 16:45:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sander Eikelenboom X-Patchwork-Id: 224117 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 268082C02B5 for ; Fri, 1 Mar 2013 03:58:04 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499Ab3B1Q6B (ORCPT ); Thu, 28 Feb 2013 11:58:01 -0500 Received: from [84.200.39.61] ([84.200.39.61]:48658 "EHLO smtp.eikelenboom.it" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932424Ab3B1Q6B (ORCPT ); Thu, 28 Feb 2013 11:58:01 -0500 X-Greylist: delayed 762 seconds by postgrey-1.27 at vger.kernel.org; Thu, 28 Feb 2013 11:58:01 EST Received: from 224-66-ftth.on.nl ([88.159.66.224]:57959 helo=[172.16.1.20]) by smtp.eikelenboom.it with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UB6ZP-0008Fg-KL; Thu, 28 Feb 2013 17:42:59 +0100 Date: Thu, 28 Feb 2013 17:45:10 +0100 From: Sander Eikelenboom Organization: Eikelenboom IT services X-Priority: 3 (Normal) Message-ID: <928867757.20130228174510@eikelenboom.it> To: Jeff Garzik , linux-kernel@vger.kernel.org CC: linux-ide@vger.kernel.org Subject: libata-acpi.c ata_acpi_register_power_resource copy and paste mistake ? MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi Jeff, During the last merge of ahci code (d9978ec5680059d727b39d6c706777c6973587f2), i saw this coming by: --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -1024,30 +1024,20 @@ static void ata_acpi_register_power_resource(struct ata_device *dev) { struct scsi_device *sdev = dev->sdev; acpi_handle handle; - struct device *device; handle = ata_dev_acpi_handle(dev); - if (!handle) - return; - - device = &sdev->sdev_gendev; - - acpi_power_resource_register_device(device, handle); + if (handle) + acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); } shouldn't: acpi_dev_pm_remove_dependent(handle, &sdev->sdev_gendev); be acpi_dev_pm_add_dependent(handle, &sdev->sdev_gendev); in the ata_acpi_register_power_resource function ? (seems like a copy and paste mistake from the unregister function) -- Sander