Patchwork [3.5.y.z,extended,stable] Patch "sunvdc: Fix off-by-one in generic_request()." has been added to staging queue

mail settings
Submitter Luis Henriques
Date Feb. 28, 2013, 11:59 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/223941/
State New
Headers show


Luis Henriques - Feb. 28, 2013, 11:59 a.m.
This is a note to let you know that I have just added a patch titled

    sunvdc: Fix off-by-one in generic_request().

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From eb889aff061a4797de018ace796b2a452f3be9e9 Mon Sep 17 00:00:00 2001
From: "David S. Miller" <>
Date: Thu, 14 Feb 2013 11:49:01 -0800
Subject: [PATCH] sunvdc: Fix off-by-one in generic_request().

commit f4d9605434c0fd4cc8639bf25cfc043418c52362 upstream.

The 'operations' bitmap corresponds one-for-one with the operation
codes, no adjustment is necessary.

Reported-by: Mark Kettenis <>
Signed-off-by: David S. Miller <>
Signed-off-by: Luis Henriques <>
 drivers/block/sunvdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
index 9dcf76a..31dd451 100644
--- a/drivers/block/sunvdc.c
+++ b/drivers/block/sunvdc.c
@@ -461,7 +461,7 @@  static int generic_request(struct vdc_port *port, u8 op, void *buf, int len)
 	int op_len, err;
 	void *req_buf;

-	if (!(((u64)1 << ((u64)op - 1)) & port->operations))
+	if (!(((u64)1 << (u64)op) & port->operations))
 		return -EOPNOTSUPP;

 	switch (op) {