Patchwork [0/4] otg-for-v3.10-v2: separate phy code and add DT helper

login
register
mail settings
Submitter Marc Kleine-Budde
Date Feb. 28, 2013, 10:52 a.m.
Message ID <1362048751-4061-1-git-send-email-mkl@pengutronix.de>
Download mbox
Permalink /patch/223881/
State New
Headers show

Pull-request

git://git.pengutronix.de/git/mkl/linux.git tags/otg-for-v3.10-v2

Comments

Marc Kleine-Budde - Feb. 28, 2013, 10:52 a.m.
Hello,

this series depends on the bugfix patch "USB otg: use try_module_get in all
usb_get_phy functions and add missing module_put" (a.k.a tags/otg-for-v3.9-v1)
posted earlier and is inteded for v3.10. It separates the phy from the otg code
and adds DT helper functions. In mxs-phy the {read,write}l_relaxed() functions
are replaced by the non _relaxed version to improve compile time coverage.
Further mxs-phy makes now use of the new usb_add_phy_dev() function to register
it's phy.

regards,
Marc

---

changes since v1:
- fix compile time breakage on non DT platforms (tnx, Alexander)
- convert mxs-phy to non _relaxed {read,write}l_relaxed() functions
  (as requested by Alexander)

---

The following changes since commit 6bef020b4aebd7886281fb7fb37c788d5a365eea:

  USB otg: use try_module_get in all usb_get_phy functions and add missing module_put (2013-02-27 12:53:15 +0100)

are available in the git repository at:

  git://git.pengutronix.de/git/mkl/linux.git tags/otg-for-v3.10-v2

for you to fetch changes up to f5678b135967ea98256ee5df9a360b5769861d23:

  USB mxs-phy: Register phy with framework (2013-02-28 11:36:45 +0100)

----------------------------------------------------------------
USB otg, phy: separate phy and add DT helper

Move phy related code into separate file and add device tree helper functions.

----------------------------------------------------------------
Marc Kleine-Budde (1):
      USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

Michael Grzeschik (1):
      USB: add devicetree helpers for determining dr_mode and phy_type

Sascha Hauer (2):
      USB: move bulk of otg/otg.c to phy/phy.c
      USB mxs-phy: Register phy with framework

 drivers/usb/otg/mxs-phy.c |   41 +++--
 drivers/usb/otg/otg.c     |  427 -------------------------------------------
 drivers/usb/phy/Makefile  |    2 +
 drivers/usb/phy/of.c      |   47 +++++
 drivers/usb/phy/phy.c     |  438 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/usb/usb-common.c  |   37 ++++
 include/linux/usb/of.h    |   28 +++
 include/linux/usb/otg.h   |    8 +
 include/linux/usb/phy.h   |    9 +
 9 files changed, 594 insertions(+), 443 deletions(-)
 create mode 100644 drivers/usb/phy/of.c
 create mode 100644 drivers/usb/phy/phy.c
 create mode 100644 include/linux/usb/of.h
Alexander Shishkin - Feb. 28, 2013, 11:25 a.m.
Marc Kleine-Budde <mkl@pengutronix.de> writes:

> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
> to the plain readl(), writel() functions, which are available on all platforms.
> This is done to enable compile time testing on non ARM platforms.
>
> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

I think it was Felipe who reported this actually.

Regards,
--
Alex
Marc Kleine-Budde - March 8, 2013, 4:05 p.m.
On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
> Marc Kleine-Budde <mkl@pengutronix.de> writes:
> 
>> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
>> to the plain readl(), writel() functions, which are available on all platforms.
>> This is done to enable compile time testing on non ARM platforms.
>>
>> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> 
> I think it was Felipe who reported this actually.

Fixed. I'm about to repost this series with crediting Felipe as reporter.

Which tree would you like to be this series based on? It depends on the
"USB otg: use try_module_get in all usb_get_phy functions and add
missing module_put" patch which is part of your usb/fixes branch, but
not in usb/next yet.

Marc
Felipe Balbi - March 8, 2013, 4:28 p.m.
Hi,

On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote:
> On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
> > Marc Kleine-Budde <mkl@pengutronix.de> writes:
> > 
> >> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
> >> to the plain readl(), writel() functions, which are available on all platforms.
> >> This is done to enable compile time testing on non ARM platforms.
> >>
> >> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > 
> > I think it was Felipe who reported this actually.
> 
> Fixed. I'm about to repost this series with crediting Felipe as reporter.
> 
> Which tree would you like to be this series based on? It depends on the
> "USB otg: use try_module_get in all usb_get_phy functions and add
> missing module_put" patch which is part of your usb/fixes branch, but
> not in usb/next yet.

look at my testing branch. I have them all already. You didn't get an
email yet because I'm waiting for -rc2 to be tagged.

I have fixed the Reported-by tag, no issues there.

Anyway, as soon as v3.9-rc2 is tagged, I will rebase testing on top of
that and move all patches to 'next', then everything will be stable from
that point on.

If you want to have changes to any of the patches, now is the time,
after I move patches to 'next' the tree becomes immutable.

cheers
Marc Kleine-Budde - March 8, 2013, 4:31 p.m.
On 03/08/2013 05:28 PM, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote:
>> On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
>>> Marc Kleine-Budde <mkl@pengutronix.de> writes:
>>>
>>>> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
>>>> to the plain readl(), writel() functions, which are available on all platforms.
>>>> This is done to enable compile time testing on non ARM platforms.
>>>>
>>>> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>>>
>>> I think it was Felipe who reported this actually.
>>
>> Fixed. I'm about to repost this series with crediting Felipe as reporter.
>>
>> Which tree would you like to be this series based on? It depends on the
>> "USB otg: use try_module_get in all usb_get_phy functions and add
>> missing module_put" patch which is part of your usb/fixes branch, but
>> not in usb/next yet.
> 
> look at my testing branch. I have them all already. You didn't get an
> email yet because I'm waiting for -rc2 to be tagged.

Thanks.

> I have fixed the Reported-by tag, no issues there.
> 
> Anyway, as soon as v3.9-rc2 is tagged, I will rebase testing on top of
> that and move all patches to 'next', then everything will be stable from
> that point on.
> 
> If you want to have changes to any of the patches, now is the time,
> after I move patches to 'next' the tree becomes immutable.

Nope, I just wanted to keep track of the patches.

Marc
Felipe Balbi - March 8, 2013, 4:34 p.m.
On Fri, Mar 08, 2013 at 05:31:41PM +0100, Marc Kleine-Budde wrote:
> On 03/08/2013 05:28 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > On Fri, Mar 08, 2013 at 05:05:58PM +0100, Marc Kleine-Budde wrote:
> >> On 02/28/2013 12:25 PM, Alexander Shishkin wrote:
> >>> Marc Kleine-Budde <mkl@pengutronix.de> writes:
> >>>
> >>>> This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed()
> >>>> to the plain readl(), writel() functions, which are available on all platforms.
> >>>> This is done to enable compile time testing on non ARM platforms.
> >>>>
> >>>> Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> >>>
> >>> I think it was Felipe who reported this actually.
> >>
> >> Fixed. I'm about to repost this series with crediting Felipe as reporter.
> >>
> >> Which tree would you like to be this series based on? It depends on the
> >> "USB otg: use try_module_get in all usb_get_phy functions and add
> >> missing module_put" patch which is part of your usb/fixes branch, but
> >> not in usb/next yet.
> > 
> > look at my testing branch. I have them all already. You didn't get an
> > email yet because I'm waiting for -rc2 to be tagged.
> 
> Thanks.
> 
> > I have fixed the Reported-by tag, no issues there.
> > 
> > Anyway, as soon as v3.9-rc2 is tagged, I will rebase testing on top of
> > that and move all patches to 'next', then everything will be stable from
> > that point on.
> > 
> > If you want to have changes to any of the patches, now is the time,
> > after I move patches to 'next' the tree becomes immutable.
> 
> Nope, I just wanted to keep track of the patches.

alright, sorry for the time it's taking to have 'next' ready, but I need
to make sure things are, at a minimum, compiling correctly. Plus, I have
dependencies on commits which I have sent to Greg as fixes. They should
be merged upstream any time now ;-)