From patchwork Thu Feb 28 10:27:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 223861 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D5AAC2C00DC for ; Thu, 28 Feb 2013 21:27:54 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362652075; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=QRU/4/Gbn1rmZ49Gd9/Frw9JzWg=; b=qdU/02k4l/aFVZj asPVh5JTIDjP+b2FHzlv70tRG9LurkUNVaaDatxF8yK5s0rIJBOgGMHmGNEPTzLl x+xas7sl7WLTG38QQvIR+u/qKyFh0Zx38/V039TbW+AQb+/5858TAzLaCRucGS0w 1/2/CIrDd8ZrBkgpso9JQ5BM6iWM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:Subject:References:In-Reply-To:X-Forwarded-Message-Id:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=chVmBXwN/G1jLBOf5ty3KncEFTnD7arrJQOd8wkut/AIvr8y4mkp51vTsk29m+ izl9duoJJQvio9bOfHhjhTxiq29YkB3vemCWWOWhOtFlWBSDjdeqFHrEie9kitWS 4AvEMqFrm6MgBkRIm4cMZaHRbpW7ca4eZpcQD4AaDVVt0=; Received: (qmail 15696 invoked by alias); 28 Feb 2013 10:27:44 -0000 Received: (qmail 15686 invoked by uid 22791); 28 Feb 2013 10:27:42 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, KHOP_THREADED, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 10:27:36 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 28 Feb 2013 10:27:33 +0000 Received: from [10.1.69.70] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Thu, 28 Feb 2013 10:27:33 +0000 Message-ID: <512F3114.2020604@arm.com> Date: Thu, 28 Feb 2013 10:27:32 +0000 From: Ramana Radhakrishnan Reply-To: ramrad01@arm.com User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org ;" Subject: [Patch ARM] Call final_start_function and final_end_function in arm_output_mi_thunk. References: <512DCC5F.7000008@arm.com> In-Reply-To: <512DCC5F.7000008@arm.com> X-Forwarded-Message-Id: <512DCC5F.7000008@arm.com> X-MC-Unique: 113022810273306401 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, Ports should call final_start_function and final_end_function to get proper debug info for the thunk as per http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55257#c3 . Fixes failing tests in g++.dg for arm-*-*eabi. Tested on arm-linux-gnueabi cross for armv7-a, arm/thumb2 and armv5t on qemu. Applied. Thanks, Ramana 2013-02-28 Ramana Radhakrishnan * config/arm/arm.c (arm_output_mi_thunk): Call final_start_function and final_end_function. --- gcc/config/arm/arm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 3e7bd7f..44fefb0 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -24314,6 +24314,8 @@ arm_output_mi_thunk (FILE *file, tree thunk ATTRIBUTE_UNUSED, if (mi_delta < 0) mi_delta = - mi_delta; + final_start_function (emit_barrier (), file, 1); + if (TARGET_THUMB1) { int labelno = thunk_label++; @@ -24430,6 +24432,8 @@ arm_output_mi_thunk (FILE *file, tree thunk ATTRIBUTE_UNUSED, fputs ("(PLT)", file); fputc ('\n', file); } + + final_end_function (); } int