From patchwork Thu Feb 28 09:38:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 223852 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 496242C0084 for ; Thu, 28 Feb 2013 20:38:50 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362649130; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=j/vInyPlEACbI6lQ24Vm0OvxvHA=; b=Sg5WSndKA69yqT2 15z2GsajHWavJTkBxy49cY44ZNqBjkWD57CkOU8AtXoG6hf+3ZJuANc1qTG14/c8 PxKZLQoNHKK8d0qGTPww+k1gsFxtrtEnH8y8ykygKjMBsLuWyp1yBxuxOYgNDkPo GR+CXKzQ1HQ8RrRZi1GKO911EsyI= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=PmfPfEeyB2S6E0b0EkQozrXv943VFrsdY5+Nkx2Hxe51sMbasd9+b8zDFcGZaT I/L2mno0n/FEH416LzivkMEvE1kLx7rI06EbLIRsrWMrTDNrHXVXmxmje4HTbi5S XAevLoBnoGtXbkTmDMcaQP+YWuJUA+veB1Uc8LyWkhAbU=; Received: (qmail 2531 invoked by alias); 28 Feb 2013 09:38:45 -0000 Received: (qmail 2503 invoked by uid 22791); 28 Feb 2013 09:38:45 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, KHOP_THREADED, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 09:38:38 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 28 Feb 2013 09:38:36 +0000 Received: from e106375-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 28 Feb 2013 09:38:34 +0000 From: James Greenhalgh To: gcc-patches@gcc.gnu.org Cc: marcus.shawcroft@arm.com Subject: [AArch64/AArch64-4.7] Fix warning - Unused variable in aarch64_float_const_representable. Date: Thu, 28 Feb 2013 09:38:30 +0000 Message-Id: <1362044310-7748-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <1362044092-7629-1-git-send-email-james.greenhalgh@arm.com> References: <1362044092-7629-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-MC-Unique: 113022809383616701 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, In aarch64_float_const_representable, `sign' is unused. This patch removes all references to it. The patch is equally applicable to trunk and aarch64-4.7-branch. This patch fixes the warning: config/aarch64/aarch64.c: In function ‘aarch64_float_const_representable_p’: config/aarch64/aarch64.c:7075:7: warning: variable ‘sign’ set but not used [-Wunused-but-set-variable] Regression tested on aarch64-none-elf with no regressions. OK for trunk and aarch64-4.7-branch? Thanks, James Greenhalgh --- gcc/ 2013-02-28 James Greenhalgh * config/aarch64/aarch64.c (aarch64_float_const_representable): Remove unused variable. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index a1e4cdd..8c8532c 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -7088,7 +7088,7 @@ aarch64_float_const_representable_p (rtx x) /* This represents our current view of how many bits make up the mantissa. */ int point_pos = 2 * HOST_BITS_PER_WIDE_INT - 1; - int sign, exponent; + int exponent; unsigned HOST_WIDE_INT mantissa, mask; HOST_WIDE_INT m1, m2; REAL_VALUE_TYPE r, m; @@ -7105,8 +7105,7 @@ aarch64_float_const_representable_p (rtx x) || REAL_VALUE_MINUS_ZERO (r)) return false; - /* Extract sign and exponent. */ - sign = REAL_VALUE_NEGATIVE (r) ? 1 : 0; + /* Extract exponent. */ r = real_value_abs (&r); exponent = REAL_EXP (&r);