Patchwork [19/19] rtc: rtc-starfire: remove erroneous __init/__exit annotations

login
register
mail settings
Submitter Jingoo Han
Date Feb. 28, 2013, 8:46 a.m.
Message ID <00b701ce1590$19b55070$4d1ff150$%han@samsung.com>
Download mbox | patch
Permalink /patch/223835/
State New
Headers show

Comments

Jingoo Han - Feb. 28, 2013, 8:46 a.m.
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-starfire.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Patch

diff --git a/drivers/rtc/rtc-starfire.c b/drivers/rtc/rtc-starfire.c
index 5be98bf..d801eb5 100644
--- a/drivers/rtc/rtc-starfire.c
+++ b/drivers/rtc/rtc-starfire.c
@@ -37,7 +37,7 @@  static const struct rtc_class_ops starfire_rtc_ops = {
 	.read_time	= starfire_read_time,
 };
 
-static int __init starfire_rtc_probe(struct platform_device *pdev)
+static int starfire_rtc_probe(struct platform_device *pdev)
 {
 	struct rtc_device *rtc = rtc_device_register("starfire", &pdev->dev,
 				     &starfire_rtc_ops, THIS_MODULE);
@@ -49,7 +49,7 @@  static int __init starfire_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __exit starfire_rtc_remove(struct platform_device *pdev)
+static int starfire_rtc_remove(struct platform_device *pdev)
 {
 	struct rtc_device *rtc = platform_get_drvdata(pdev);
 
@@ -63,7 +63,7 @@  static struct platform_driver starfire_rtc_driver = {
 		.name	= "rtc-starfire",
 		.owner	= THIS_MODULE,
 	},
-	.remove		= __exit_p(starfire_rtc_remove),
+	.remove		= starfire_rtc_remove,
 };
 
 static int __init starfire_rtc_init(void)