From patchwork Thu Feb 28 08:44:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 223831 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f187.google.com (mail-gh0-f187.google.com [209.85.160.187]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8FE522C0091 for ; Thu, 28 Feb 2013 19:44:52 +1100 (EST) Received: by mail-gh0-f187.google.com with SMTP id 16sf662868ghy.24 for ; Thu, 28 Feb 2013 00:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=CAbb4Ka5VGzmFeW7lpljttjDSNEjkxShsczD1667tw8=; b=k/DU9GOWHbw+oUD/QiYzsczQ/44FRsr8f6f/aHS8hrlUK0U7/qD+HEgbVGMb2+n5Ft L3PfbIIu3xnevA9ZnnYPBi9eOKegCvS8dGqfCLwwoqWkKRe702HOmkwV120FpuvDpeiW LL4KGwxa9Rv3B/AkmzsSNHCBPVh0X/fYldVKSCRc1+9UWnUQvFWhsWBDjiyinCbkvHF7 rsYLTsDtgfoCplhju2AfJYEhlpmmfEJC8RC47yD4nvP23LPCRP5428brTK8Y4WuPjwU/ 52xVsCbJGI6YeI3Pv7f/tDD1sRGtL8CKlUgz7IjvNVRNK4tmzjRb7wtvSeunm2aC3q7g Ciaw== X-Received: by 10.50.135.10 with SMTP id po10mr376316igb.4.1362041089916; Thu, 28 Feb 2013 00:44:49 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.46.230 with SMTP id y6ls892189igm.43.gmail; Thu, 28 Feb 2013 00:44:49 -0800 (PST) X-Received: by 10.66.52.48 with SMTP id q16mr1510064pao.31.1362041089545; Thu, 28 Feb 2013 00:44:49 -0800 (PST) X-Received: by 10.66.52.48 with SMTP id q16mr1510063pao.31.1362041089536; Thu, 28 Feb 2013 00:44:49 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id c2si1778919pax.2.2013.02.28.00.44.49; Thu, 28 Feb 2013 00:44:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIX00I9X9MANLD0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Thu, 28 Feb 2013 17:44:48 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 59.53.02494.0091F215; Thu, 28 Feb 2013 17:44:48 +0900 (KST) X-AuditID: cbfee68d-b7f636d0000009be-d4-512f1900ca7a Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 30.46.03880.0091F215; Thu, 28 Feb 2013 17:44:48 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIX00LMF9MOKC50@mmp1.samsung.com> for rtc-linux@googlegroups.com; Thu, 28 Feb 2013 17:44:48 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <00a501ce158e$ef171610$cd454230$%han@samsung.com> In-reply-to: <00a501ce158e$ef171610$cd454230$%han@samsung.com> Subject: [rtc-linux] [PATCH 15/19] rtc: rtc-tx4939: remove erroneous __init/__exit annotations Date: Thu, 28 Feb 2013 17:44:48 +0900 Message-id: <00b301ce158f$ddb0ef30$9912cd90$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4Vju7DHmrOxtsNRmyyH1DU6RVYuAAAOKgw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t8zA10GSf1AgytzNSz2d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoEr4+itVpaCD9wVLXMvMjYw/uTsYuTgkBAwkfj8i6uLkRPIFJO4 cG89WxcjF4eQwDJGiR8/DzFBJEwkOh70s0MkFjFKHFp5H8qZySSx9P0yRpAqNgE1iS9fDrOD TBUR0Jdoa9EAqWEW6GWUONO7mx2kRkjAVuJYWxsLiM0pYCfx++lRVpB6YYEQifOvHUHCLAKq EnP6doCV8AKVv1u9lBHCFpT4MfkeWJxZQEti/c7jTBC2vMTmNW+ZIZ5Rl3j0VxckLCJgJDHp 8TJmiBIRiX0v3jFC/LKMXeLL+VyIVQIS3yYfYoFolZXYdIAZokRS4uCKGywTGCVmIVk8C8ni WUgWz0KyYQEjyypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MkLjq3cF4+4D1IcZkoPUTmaVE k/OBcZlXEm9obGxiZmJqYm5pam5KmrCSOK/cJZlAIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxS DYz6MdfPV5oUlcbLvl7eE96rL7QxRXp2kvHvd/yTOFkcxUwdZYNSjovWsuyKmXj2i6Ij8x+O uKiKKTYGivzh9/Xt/Zk9Gdo8wlv8pixhaNySJdm6f4JO2zlut6jw2BWHNn+bpbfT3Sv26qP6 GuFlWZxpTZ+Up3c6V8zq3Z9cNzn/RGlpo8tbJZbijERDLeai4kQAOgCUBsECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgC6DpH6gwdU1Khb7OzsYHRg99kw8 yRbAGNXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkD NFZJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHH0VitLwQfuipa5Fxkb GH9ydjFyckgImEh0POhnh7DFJC7cW8/WxcjFISSwiFHi0Mr77BDOTCaJpe+XMYJUsQmoSXz5 chgowcEhIqAv0daiAVLDLNDLKHGmdzfYJCEBW4ljbW0sIDangJ3E76dHWUHqhQVCJM6/dgQJ swioSszp2wFWwgtU/m71UkYIW1Dix+R7YHFmAS2J9TuPM0HY8hKb17xlBhkjIaAu8eivLkhY RMBIYtLjZcwQJSIS+168Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL 89L1kvNzNzGCI/eZ9A7GVQ0WhxgFOBiVeHg7TPQChVgTy4orcw8xSnAwK4nwuvDrBwrxpiRW VqUW5ccXleakFh9iTAZ6dCKzlGhyPjCp5JXEGxqbmBlZGplZGJmYm5MmrCTOy3jqSYCQQHpi SWp2ampBahHMFiYOTqkGxg5ujo3On5xUJqtJvElOmPwj9pzb3f1zlgiFFHE0MqtZawfdD93W aLG5T3nu9eqbipt/Sm6a6K923+zxoU17GQ6l5KcVhjzZuX3GwmfFb73UXm+teSbuHtDt7r6K +Y3dmbT/b5tWLtTiOGJ36J/J6lq2L5t+yLx2Ngnjvmg+b4WfvDpLttPsO0osxRmJhlrMRcWJ AOx4tXwgAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko __init/__exit annotations for probe()/remove() are supposed to be __devinit/__devexit, because __init/__exit for probe()/remove() are not correct. However, __devinit/__devexit are not used, because CONFIG_HOTPLUG was removed. Thus, these annotations should be removed. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-tx4939.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index a12bfac..f197773 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c @@ -237,7 +237,7 @@ static struct bin_attribute tx4939_rtc_nvram_attr = { .write = tx4939_rtc_nvram_write, }; -static int __init tx4939_rtc_probe(struct platform_device *pdev) +static int tx4939_rtc_probe(struct platform_device *pdev) { struct rtc_device *rtc; struct tx4939rtc_plat_data *pdata; @@ -279,7 +279,7 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev) return ret; } -static int __exit tx4939_rtc_remove(struct platform_device *pdev) +static int tx4939_rtc_remove(struct platform_device *pdev) { struct tx4939rtc_plat_data *pdata = platform_get_drvdata(pdev); @@ -292,7 +292,7 @@ static int __exit tx4939_rtc_remove(struct platform_device *pdev) } static struct platform_driver tx4939_rtc_driver = { - .remove = __exit_p(tx4939_rtc_remove), + .remove = tx4939_rtc_remove, .driver = { .name = "tx4939rtc", .owner = THIS_MODULE,