diff mbox

net/8021q: beautify code, name_type is unsigned int, always >= 0

Message ID 512F0C7F.1010304@asianux.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Chen Gang Feb. 28, 2013, 7:51 a.m. UTC 
args.u.name_type is unsigned int, which is always >= 0

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 net/8021q/vlan.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index a187144..0f5261a 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -571,8 +571,7 @@  static int vlan_ioctl_handler(struct net *net, void __user *arg)
 		err = -EPERM;
 		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
 			break;
-		if ((args.u.name_type >= 0) &&
-		    (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) {
+		if (args.u.name_type < VLAN_NAME_TYPE_HIGHEST) {
 			struct vlan_net *vn;
 
 			vn = net_generic(net, vlan_net_id);