Patchwork Fix ipa-pure-const memory leak (PR middle-end/56461)

login
register
mail settings
Submitter Jakub Jelinek
Date Feb. 27, 2013, 4:03 p.m.
Message ID <20130227160353.GM12913@tucnak.redhat.com>
Download mbox | patch
Permalink /patch/223645/
State New
Headers show

Comments

Jakub Jelinek - Feb. 27, 2013, 4:03 p.m.
Hi!

The release_node hook is only called when a cgraph node is removed, not
when it merely gets ->analyzed field cleared.  If that happens on
some node that has_function_state, we leak the memory.

Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
ok for trunk?

2013-02-27  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/56461
	* ipa-pure-const.c (propagate): Use FOR_EACH_FUNCTION instead of
	FOR_EACH_DEFINED_FUNCTION when freeing state.


	Jakub
Richard Guenther - Feb. 27, 2013, 7:52 p.m.
On 2/27/13 5:03 PM, Jakub Jelinek wrote:
> Hi!
> 
> The release_node hook is only called when a cgraph node is removed, not
> when it merely gets ->analyzed field cleared.  If that happens on
> some node that has_function_state, we leak the memory.
> 
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
> ok for trunk?

Ok.

Thanks,
Richard.

> 2013-02-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR middle-end/56461
> 	* ipa-pure-const.c (propagate): Use FOR_EACH_FUNCTION instead of
> 	FOR_EACH_DEFINED_FUNCTION when freeing state.
> 
> --- gcc/ipa-pure-const.c.jj	2013-02-08 13:16:55.000000000 +0100
> +++ gcc/ipa-pure-const.c	2013-02-27 11:20:54.876786950 +0100
> @@ -1479,7 +1479,7 @@ propagate (void)
>    propagate_pure_const ();
>  
>    /* Cleanup. */
> -  FOR_EACH_DEFINED_FUNCTION (node)
> +  FOR_EACH_FUNCTION (node)
>      if (has_function_state (node))
>        free (get_function_state (node));
>    funct_state_vec.release ();
> 
> 	Jakub
>

Patch

--- gcc/ipa-pure-const.c.jj	2013-02-08 13:16:55.000000000 +0100
+++ gcc/ipa-pure-const.c	2013-02-27 11:20:54.876786950 +0100
@@ -1479,7 +1479,7 @@  propagate (void)
   propagate_pure_const ();
 
   /* Cleanup. */
-  FOR_EACH_DEFINED_FUNCTION (node)
+  FOR_EACH_FUNCTION (node)
     if (has_function_state (node))
       free (get_function_state (node));
   funct_state_vec.release ();