Patchwork [7/8] acpi: syntaxcheck: add some more per-table information in log

login
register
mail settings
Submitter Colin King
Date Feb. 27, 2013, 2:40 p.m.
Message ID <1361976054-28357-8-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/223619/
State Accepted
Headers show

Comments

Colin King - Feb. 27, 2013, 2:40 p.m.
From: Colin Ian King <colin.king@canonical.com>

Currently it is hard to see where the per-table tests start and end
so add a heading and some more newlines to make it easier to see in
the log.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/syntaxcheck/syntaxcheck.c | 6 ++++++
 1 file changed, 6 insertions(+)
Alex Hung - March 4, 2013, 10:16 a.m.
On 02/27/2013 10:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently it is hard to see where the per-table tests start and end
> so add a heading and some more newlines to make it easier to see in
> the log.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/syntaxcheck/syntaxcheck.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
> index 185f43a..5d0ae6c 100644
> --- a/src/acpi/syntaxcheck/syntaxcheck.c
> +++ b/src/acpi/syntaxcheck/syntaxcheck.c
> @@ -451,6 +451,10 @@ static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
>   		return FWTS_ERROR;
>   	}
>
> +	fwts_log_nl(fw);
> +	fwts_log_info(fw, "Checking ACPI table %s (#%d)", tablename, which);
> +	fwts_log_nl(fw);
> +
>   	if (iasl_errors) {
>   		/* Scan error text from assembly */
>   		fwts_list_foreach(item, iasl_errors) {
> @@ -549,6 +553,8 @@ static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
>   	} else
>   		fwts_passed(fw, "%s (%d) reassembly, Found 0 errors, 0 warnings.", tablename, which);
>
> +	fwts_log_nl(fw);
> +
>   	return FWTS_OK;
>   }
>
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - March 5, 2013, 8:29 a.m.
On Wed, Feb 27, 2013 at 10:40 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently it is hard to see where the per-table tests start and end
> so add a heading and some more newlines to make it easier to see in
> the log.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/syntaxcheck/syntaxcheck.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
> index 185f43a..5d0ae6c 100644
> --- a/src/acpi/syntaxcheck/syntaxcheck.c
> +++ b/src/acpi/syntaxcheck/syntaxcheck.c
> @@ -451,6 +451,10 @@ static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
>                 return FWTS_ERROR;
>         }
>
> +       fwts_log_nl(fw);
> +       fwts_log_info(fw, "Checking ACPI table %s (#%d)", tablename, which);
> +       fwts_log_nl(fw);
> +
>         if (iasl_errors) {
>                 /* Scan error text from assembly */
>                 fwts_list_foreach(item, iasl_errors) {
> @@ -549,6 +553,8 @@ static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
>         } else
>                 fwts_passed(fw, "%s (%d) reassembly, Found 0 errors, 0 warnings.", tablename, which);
>
> +       fwts_log_nl(fw);
> +
>         return FWTS_OK;
>  }
>
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/acpi/syntaxcheck/syntaxcheck.c b/src/acpi/syntaxcheck/syntaxcheck.c
index 185f43a..5d0ae6c 100644
--- a/src/acpi/syntaxcheck/syntaxcheck.c
+++ b/src/acpi/syntaxcheck/syntaxcheck.c
@@ -451,6 +451,10 @@  static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
 		return FWTS_ERROR;
 	}
 
+	fwts_log_nl(fw);
+	fwts_log_info(fw, "Checking ACPI table %s (#%d)", tablename, which);
+	fwts_log_nl(fw);
+
 	if (iasl_errors) {
 		/* Scan error text from assembly */
 		fwts_list_foreach(item, iasl_errors) {
@@ -549,6 +553,8 @@  static int syntaxcheck_table(fwts_framework *fw, char *tablename, int which)
 	} else
 		fwts_passed(fw, "%s (%d) reassembly, Found 0 errors, 0 warnings.", tablename, which);
 
+	fwts_log_nl(fw);
+
 	return FWTS_OK;
 }