Patchwork [8/8] data: syntaxcheck: add a few more advice entries

login
register
mail settings
Submitter Colin King
Date Feb. 27, 2013, 2:40 p.m.
Message ID <1361976054-28357-9-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/223617/
State Accepted
Headers show

Comments

Colin King - Feb. 27, 2013, 2:40 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add some missing advice entries for some more specific errors

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/syntaxcheck.json | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
Alex Hung - March 4, 2013, 10:17 a.m.
On 02/27/2013 10:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add some missing advice entries for some more specific errors
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/syntaxcheck.json | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/data/syntaxcheck.json b/data/syntaxcheck.json
> index e9c61ea..b3ceb55 100644
> --- a/data/syntaxcheck.json
> +++ b/data/syntaxcheck.json
> @@ -2,6 +2,22 @@
>    "erroradvice":
>    [
>     {
> +   "id": "ASL_MSG_RETURN_TYPES",
> +   "advice": "Some of the execution paths do not return a value.  All control paths that return must return a value otherwise unepected behaviour may occur.  This error occurs because a branch on an conditional op-code returns a value and another does not, which is inconsitent behaviour."
> +  },
> +  {
> +   "id": "ASL_MSG_RESERVED_RETURN_VALUE",
> +   "advice": "A reserved method was expected to return a value, however, it does not. This is unexpected behaviour that does not conform the the ACPI specification."
> +  },
> +  {
> +   "id": "ASL_MSG_INVALID_TYPE",
> +   "advice": "An invalid type was used.  A different type was expected to be used.",
> +  },
> +  {
> +   "id": "ASL_MSG_RESERVED_NO_RETURN_VAL",
> +   "advice": "A reserved method returned a value however it is not expected to return anything, so this does not conform to the expected behaviour.  The kernel will most probably ignore the return value, so this is not going to produce any run time errors."
> +  },
> +  {
>      "id": "ASL_MSG_ALIGNMENT",
>      "advice": "Addresses must be an exact multiple of the alignment value."
>     },
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - March 5, 2013, 8:29 a.m.
On Wed, Feb 27, 2013 at 10:40 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add some missing advice entries for some more specific errors
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/syntaxcheck.json | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/data/syntaxcheck.json b/data/syntaxcheck.json
> index e9c61ea..b3ceb55 100644
> --- a/data/syntaxcheck.json
> +++ b/data/syntaxcheck.json
> @@ -2,6 +2,22 @@
>   "erroradvice":
>   [
>    {
> +   "id": "ASL_MSG_RETURN_TYPES",
> +   "advice": "Some of the execution paths do not return a value.  All control paths that return must return a value otherwise unepected behaviour may occur.  This error occurs because a branch on an conditional op-code returns a value and another does not, which is inconsitent behaviour."
> +  },
> +  {
> +   "id": "ASL_MSG_RESERVED_RETURN_VALUE",
> +   "advice": "A reserved method was expected to return a value, however, it does not. This is unexpected behaviour that does not conform the the ACPI specification."
> +  },
> +  {
> +   "id": "ASL_MSG_INVALID_TYPE",
> +   "advice": "An invalid type was used.  A different type was expected to be used.",
> +  },
> +  {
> +   "id": "ASL_MSG_RESERVED_NO_RETURN_VAL",
> +   "advice": "A reserved method returned a value however it is not expected to return anything, so this does not conform to the expected behaviour.  The kernel will most probably ignore the return value, so this is not going to produce any run time errors."
> +  },
> +  {
>     "id": "ASL_MSG_ALIGNMENT",
>     "advice": "Addresses must be an exact multiple of the alignment value."
>    },
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/syntaxcheck.json b/data/syntaxcheck.json
index e9c61ea..b3ceb55 100644
--- a/data/syntaxcheck.json
+++ b/data/syntaxcheck.json
@@ -2,6 +2,22 @@ 
  "erroradvice": 
  [ 
   {
+   "id": "ASL_MSG_RETURN_TYPES",
+   "advice": "Some of the execution paths do not return a value.  All control paths that return must return a value otherwise unepected behaviour may occur.  This error occurs because a branch on an conditional op-code returns a value and another does not, which is inconsitent behaviour."
+  },
+  {
+   "id": "ASL_MSG_RESERVED_RETURN_VALUE",
+   "advice": "A reserved method was expected to return a value, however, it does not. This is unexpected behaviour that does not conform the the ACPI specification."
+  },
+  {
+   "id": "ASL_MSG_INVALID_TYPE",
+   "advice": "An invalid type was used.  A different type was expected to be used.",
+  },
+  {
+   "id": "ASL_MSG_RESERVED_NO_RETURN_VAL",
+   "advice": "A reserved method returned a value however it is not expected to return anything, so this does not conform to the expected behaviour.  The kernel will most probably ignore the return value, so this is not going to produce any run time errors."
+  },
+  {
    "id": "ASL_MSG_ALIGNMENT",
    "advice": "Addresses must be an exact multiple of the alignment value."
   },