Patchwork net: cdc_ncm: tag Huawei devices (e.g. E5331) with FLAG_WWAN

login
register
mail settings
Submitter Bjørn Mork
Date Feb. 27, 2013, 1:08 p.m.
Message ID <1361970538-24451-1-git-send-email-bjorn@mork.no>
Download mbox | patch
Permalink /patch/223596/
State Accepted
Delegated to: David Miller
Headers show

Comments

Bjørn Mork - Feb. 27, 2013, 1:08 p.m.
Tag all Huawei NCM devices as WWAN modems, as we don't know of any which
are not.  This is necessary for userspace clients to know that the device
requires further setup on e.g. an AT-capable serial ports before
connectivity is available.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 drivers/net/usb/cdc_ncm.c |    8 ++++++++
 1 file changed, 8 insertions(+)
David Miller - Feb. 27, 2013, 6:12 p.m.
From: Bjørn Mork <bjorn@mork.no>
Date: Wed, 27 Feb 2013 14:08:58 +0100

> Tag all Huawei NCM devices as WWAN modems, as we don't know of any which
> are not.  This is necessary for userspace clients to know that the device
> requires further setup on e.g. an AT-capable serial ports before
> connectivity is available.
> 
> Signed-off-by: Bjørn Mork <bjorn@mork.no>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 4a8c25a..61b74a2 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1213,6 +1213,14 @@  static const struct usb_device_id cdc_devs[] = {
 	  .driver_info = (unsigned long) &wwan_info,
 	},
 
+	/* tag Huawei devices as wwan */
+	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1,
+					USB_CLASS_COMM,
+					USB_CDC_SUBCLASS_NCM,
+					USB_CDC_PROTO_NONE),
+	  .driver_info = (unsigned long)&wwan_info,
+	},
+
 	/* Huawei NCM devices disguised as vendor specific */
 	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, 0xff, 0x02, 0x16),
 	  .driver_info = (unsigned long)&wwan_info,