Patchwork [net] bnx2x: fix UDP checksum for 57710/57711.

login
register
mail settings
Submitter Dmitry Kravkov
Date Feb. 27, 2013, 10:04 a.m.
Message ID <1361959499-3968-1-git-send-email-dmitry@broadcom.com>
Download mbox | patch
Permalink /patch/223576/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dmitry Kravkov - Feb. 27, 2013, 10:04 a.m.
Since commit 86564c3f "bnx2x: Remove many sparse warnings" UDP
csum offload is broken for 57710/57711. Fix return value.

Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
CC: Ariel Elior <ariele@broadcom.com>
CC: Yuval Mintz <yuvalmin@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Feb. 27, 2013, 6:12 p.m.
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Wed, 27 Feb 2013 12:04:59 +0200

> Since commit 86564c3f "bnx2x: Remove many sparse warnings" UDP
> csum offload is broken for 57710/57711. Fix return value.
> 
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index ecac04a3..a923bc4 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -3142,7 +3142,7 @@  static inline __le16 bnx2x_csum_fix(unsigned char *t_header, u16 csum, s8 fix)
 		tsum = ~csum_fold(csum_add((__force __wsum) csum,
 				  csum_partial(t_header, -fix, 0)));
 
-	return bswab16(csum);
+	return bswab16(tsum);
 }
 
 static inline u32 bnx2x_xmit_type(struct bnx2x *bp, struct sk_buff *skb)