Patchwork drivers/isdn: beautify code, delete 'break' after 'return'

login
register
mail settings
Submitter Chen Gang
Date Feb. 27, 2013, 9:16 a.m.
Message ID <512DCEDC.4030500@asianux.com>
Download mbox | patch
Permalink /patch/223563/
State Rejected
Delegated to: David Miller
Headers show

Comments

Chen Gang - Feb. 27, 2013, 9:16 a.m.
delete 'break' statement after 'return' statement

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 drivers/isdn/i4l/isdn_tty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Chen Gang - March 15, 2013, 2:04 a.m.
Hello Maintainers:

  is it patch ok ?

  thanks.

于 2013年02月27日 17:16, Chen Gang 写道:
> 
>   delete 'break' statement after 'return' statement
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  drivers/isdn/i4l/isdn_tty.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
> index d8a7d83..925a7ed 100644
> --- a/drivers/isdn/i4l/isdn_tty.c
> +++ b/drivers/isdn/i4l/isdn_tty.c
> @@ -3425,7 +3425,6 @@ isdn_tty_parse_at(modem_info *info)
>  			p++;
>  			isdn_tty_cmd_ATA(info);
>  			return;
> -			break;
>  		case 'D':
>  			/* D - Dial */
>  			if (info->msr & UART_MSR_DCD)
>
Jiri Kosina - March 18, 2013, 1:25 p.m.
On Fri, 15 Mar 2013, Chen Gang wrote:

> Hello Maintainers:
> 
>   is it patch ok ?

This one is now applied.
Chen Gang - March 19, 2013, 12:53 a.m.
On 2013年03月18日 21:25, Jiri Kosina wrote:
> On Fri, 15 Mar 2013, Chen Gang wrote:
> 
>> > Hello Maintainers:
>> > 
>> >   is it patch ok ?
> This one is now applied.

  thanks.

Patch

diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
index d8a7d83..925a7ed 100644
--- a/drivers/isdn/i4l/isdn_tty.c
+++ b/drivers/isdn/i4l/isdn_tty.c
@@ -3425,7 +3425,6 @@  isdn_tty_parse_at(modem_info *info)
 			p++;
 			isdn_tty_cmd_ATA(info);
 			return;
-			break;
 		case 'D':
 			/* D - Dial */
 			if (info->msr & UART_MSR_DCD)