From patchwork Wed Feb 27 07:15:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuo-Jung Su X-Patchwork-Id: 223536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A0B932C007B for ; Wed, 27 Feb 2013 19:07:12 +1100 (EST) Received: from localhost ([::1]:37783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAbH1-0000qd-9d for incoming@patchwork.ozlabs.org; Wed, 27 Feb 2013 02:17:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAbFp-0007KP-9e for qemu-devel@nongnu.org; Wed, 27 Feb 2013 02:16:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UAbFm-000409-S2 for qemu-devel@nongnu.org; Wed, 27 Feb 2013 02:16:41 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:49397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAbFm-0003zu-Lp for qemu-devel@nongnu.org; Wed, 27 Feb 2013 02:16:38 -0500 Received: by mail-pa0-f53.google.com with SMTP id bg4so256575pad.12 for ; Tue, 26 Feb 2013 23:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=0n6w2rmpSeotLI0XXt5EU8I8RLvWh6Ovxe1t/M4C7+8=; b=G1+THfWqAzR6sFVrxiGkR2lAD+fswCEzw/k0cpFOovkyPUE6OfxsjESZUj7RwZ1zUX uzryRQ0ol9BXv+rp+XiRq/vSmBlKI7BXuC1l9eR23RaEMcY4SOHr3fuvlk2tAy4Vsqaj LU3p0MpfVV/GQdTEeD83UN6qaSuxNZhkuRsSw6d0aDXE/+72DpYo6+zLuvKyXoVu94b+ IQvxfc9MqA/wX++SItOkAHH11Em3Wwgdw4A8azahUvWrlcdeWtlAauzDLrxfp7da4KeH u5k6SkDZ8HTfz134arOTpIlGr4QrDPb0VsuyjIF76xgHrLpv1e8lDj21BQRo2ebMkaJR XilQ== X-Received: by 10.68.204.68 with SMTP id kw4mr1841112pbc.113.1361949397845; Tue, 26 Feb 2013 23:16:37 -0800 (PST) Received: from localhost.localdomain ([220.132.37.35]) by mx.google.com with ESMTPS id vd4sm3686032pbc.35.2013.02.26.23.16.35 (version=TLSv1 cipher=DES-CBC3-SHA bits=168/168); Tue, 26 Feb 2013 23:16:37 -0800 (PST) From: Kuo-Jung Su To: qemu-devel@nongnu.org Date: Wed, 27 Feb 2013 15:15:38 +0800 Message-Id: <1361949350-22241-13-git-send-email-dantesu@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1361949350-22241-1-git-send-email-dantesu@gmail.com> References: <1361949350-22241-1-git-send-email-dantesu@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.53 Cc: Peter Maydell , i.mitsyanko@samsung.com, Blue Swirl , Paul Brook , Kuo-Jung Su , Andreas , fred.konrad@greensocs.com Subject: [Qemu-devel] [PATCH v5 12/24] hw/nand.c: bug fix to erase operation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Kuo-Jung Su The s->addr should be reset along with the s->addrlen, or it might have the previous address shifted to MSB and then causes problem to nand erase operation. Signed-off-by: Kuo-Jung Su --- hw/nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nand.c b/hw/nand.c index 7f40ebf..3cf91c5 100644 --- a/hw/nand.c +++ b/hw/nand.c @@ -511,6 +511,7 @@ void nand_setio(DeviceState *dev, uint32_t value) nand_command(s); if (s->cmd != NAND_CMD_RANDOMREAD2) { + s->addr = 0; s->addrlen = 0; } }