From patchwork Wed Feb 27 05:58:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 223512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vc0-f187.google.com (mail-vc0-f187.google.com [209.85.220.187]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 92EF02C0040 for ; Wed, 27 Feb 2013 16:58:59 +1100 (EST) Received: by mail-vc0-f187.google.com with SMTP id l6sf73068vcl.14 for ; Tue, 26 Feb 2013 21:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=Uz2e46OzGJnx+WScUim94Ne5mlCzPo2yNfKWtMMA9cY=; b=IDko6wYyE2ztZlTm+fNlAZrJzxqx4pAE186G1jnQMQLk5YwhZbZoAB7TQiD/ccoEj7 9j39ZyvwiTPyv5I/0LrrLuof/UVT6s/br+oHxJJUjmthI1b015idHdU6gErQABjLAag5 HMe7J1W1HKhhp8Rupp+mPH6CATNvRISdmurUXEySCFudc7JRfLylxbmq9oGLNJlXGCZa wHaU+bw/TTAMmxDLm+2i5sk8bVrRUWaVqTVaYUa1zO8OcDLqMXZ/fQ3+lKlVSP30fQsb 66rW8uoxdGcAMZJhjdWQ3iZR0W4Bp96Ydq+uyB78bARBuhpXhx7a1R0GZQbVaiAIvfSI Ambg== X-Received: by 10.50.33.175 with SMTP id s15mr2047512igi.8.1361944736470; Tue, 26 Feb 2013 21:58:56 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.46.129 with SMTP id v1ls1017796igm.33.canary; Tue, 26 Feb 2013 21:58:55 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr127623pbc.6.1361944735879; Tue, 26 Feb 2013 21:58:55 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr127622pbc.6.1361944735868; Tue, 26 Feb 2013 21:58:55 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id ka10si743366pbb.2.2013.02.26.21.58.55; Tue, 26 Feb 2013 21:58:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIV000237A6Z3G0@mailout2.samsung.com> for rtc-linux@googlegroups.com; Wed, 27 Feb 2013 14:58:55 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id BA.82.25214.E90AD215; Wed, 27 Feb 2013 14:58:54 +0900 (KST) X-AuditID: cbfee68e-b7fa46d00000627e-fe-512da09e13c1 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 05.5E.03918.E90AD215; Wed, 27 Feb 2013 14:58:54 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIV00DI17A6UA30@mmp2.samsung.com>; Wed, 27 Feb 2013 14:58:54 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jonghwa Lee' , 'Jingoo Han' References: <008f01ce14af$4283cf90$c78b6eb0$%han@samsung.com> In-reply-to: <008f01ce14af$4283cf90$c78b6eb0$%han@samsung.com> Subject: [rtc-linux] [PATCH 5/5] rtc: max77686: use dev_info()/dev_emerg() instead of pr_info()/pr_emerg() Date: Wed, 27 Feb 2013 14:58:54 +0900 Message-id: <009301ce14af$863d9c20$92b8d460$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4Ur0Jf3bJm/gOXS5uxDgC3uRXcVgAADaJA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t8zY915C3QDDRo3W1osuXiV3WLO+jVs FpcXXmK16Dz7hNni8q45bBb7OzsYHdg89kw8yeZxYsZvFo++LasYPabP+8nk8XmTXABrFJdN SmpOZllqkb5dAlfG9N0PWQpeclecmfOZrYHxEWcXIyeHhICJxJaTp5ggbDGJC/fWs3UxcnEI CSxjlFj2fDYzTNGl3k5WiMR0RomTZ/YygiSEBH4xSjz4LwxiswmoSXz5cpi9i5GDQ0RAX6Kt RQOknllgJ6PEw9W3oeptJTb9OMsGYnMK2Eks/LqVDaReWCBBYsXTapAwi4CqRNO3CcwgYV6g 8i3vi0DCvAKCEj8m32MBsZkFtCTW7zzOBGHLS2xe8xasXEJAXeLRX12QsIiAkcSMe5vZIUpE JPa9eMcIco2EwFt2ie//N7JArBKQ+Db5EAtEr6zEpgNQ30pKHFxxg2UCo8QsJJtnIdk8C8nm WUhWLGBkWcUomlqQXFCclF5kpFecmFtcmpeul5yfu4kREq99OxhvHrA+xJgMtH4is5Rocj4w 3vNK4g2NjU3MTExNzC1NzU1JE1YS55W/JBMoJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgTH/ HMspB1OnDP1H+hGGO3PPb7vfwWZ/8KWKmeEKgcLLFSFnzl/3sFU/F854fNsjbfV5mguPWnC8 ip+yITnq6bHugKLXzfV9pben3xN4pPRf1paHTVlr96wPmysfqd+5fSbj/qPuyq2aC8yb7mS1 OTKofbwudjqi7dVZHn7NrXIHJD+zZAcwXlViKc5INNRiLipOBABYLqAm7QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsVy+t9jQd15C3QDDd5cMbFYcvEqu8Wc9WvY LC4vvMRq0Xn2CbPF5V1z2Cz2d3YwOrB57Jl4ks3jxIzfLB59W1Yxekyf95PJ4/MmuQDWqAZG m4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygE5QUyhJz SoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGdN3P2QpeMldcWbOZ7YGxkecXYyc HBICJhKXejtZIWwxiQv31rN1MXJxCAlMZ5Q4eWYvI0hCSOAXo8SD/8IgNpuAmsSXL4fZuxg5 OEQE9CXaWjRA6pkFdjJKPFx9G6reVmLTj7NsIDangJ3Ewq9b2UDqhQUSJFY8rQYJswioSjR9 m8AMEuYFKt/yvggkzCsgKPFj8j0WEJtZQEti/c7jTBC2vMTmNW/ByiUE1CUe/dUFCYsIGEnM uLeZHaJERGLfi3eMExiFZiGZNAvJpFlIJs1C0rKAkWUVo2hqQXJBcVJ6rqFecWJucWleul5y fu4mRnAyeCa1g3Flg8UhRgEORiUe3gWXdAKFWBPLiitzDzFKcDArifB+PAAU4k1JrKxKLcqP LyrNSS0+xJgM9OdEZinR5HxgosoriTc0NjEzsjQyszAyMTcnTVhJnJfx1JMAIYH0xJLU7NTU gtQimC1MHJxSDYwKladnOoSeMOiIP71/3qH/M1XEOLYG9TEYizHtseaZ5NKW+WHC04ufbt5p DD3RdFjqmcn1FraFle1uc35Ml+hs4o7nXjD/raP4gozCiptGxgcOKjdt8SoqZ3UNXTLtmek8 zji5e1eE7p+uFM0ya6sWq3DwnK4RMpGhpPh+95Jv5vl98ceYJiqxFGckGmoxFxUnAgBVtODl SgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko dev_info()/dev_emerg() are more preferred than pr_info()/pr_emerg(). Signed-off-by: Jingoo Han --- drivers/rtc/rtc-max77686.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 9de93e7..df66bab 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -466,7 +466,7 @@ static void max77686_rtc_enable_smpl(struct max77686_rtc_info *info, bool enable val = 0; regmap_read(info->max77686->rtc_regmap, MAX77686_WTSR_SMPL_CNTL, &val); - pr_info("%s: WTSR_SMPL(0x%02x)\n", __func__, val); + dev_info(info->dev, "%s: WTSR_SMPL(0x%02x)\n", __func__, val); } #endif /* MAX77686_RTC_WTSR_SMPL */ @@ -589,11 +589,14 @@ static void max77686_rtc_shutdown(struct platform_device *pdev) for (i = 0; i < 3; i++) { max77686_rtc_enable_wtsr(info, false); regmap_read(info->max77686->rtc_regmap, MAX77686_WTSR_SMPL_CNTL, &val); - pr_info("%s: WTSR_SMPL reg(0x%02x)\n", __func__, val); - if (val & WTSR_EN_MASK) - pr_emerg("%s: fail to disable WTSR\n", __func__); - else { - pr_info("%s: success to disable WTSR\n", __func__); + dev_info(info->dev, "%s: WTSR_SMPL reg(0x%02x)\n", __func__, + val); + if (val & WTSR_EN_MASK) { + dev_emerg(info->dev, "%s: fail to disable WTSR\n", + __func__); + } else { + dev_info(info->dev, "%s: success to disable WTSR\n", + __func__); break; } }