Patchwork [U-Boot,1/4] EXYNOS5: FDT: Add compatible strings for Serial

login
register
mail settings
Submitter Rajeshwari Birje
Date Feb. 27, 2013, 6:01 a.m.
Message ID <1361944919-13384-2-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/223507/
State Superseded
Delegated to: Minkyu Kang
Headers show

Comments

Rajeshwari Birje - Feb. 27, 2013, 6:01 a.m.
Add required compatible information for s5p serial driver

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
 include/fdtdec.h |    1 +
 lib/fdtdec.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
Simon Glass - Feb. 28, 2013, 1:19 a.m.
Hi

On Tue, Feb 26, 2013 at 10:01 PM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> Add required compatible information for s5p serial driver
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  include/fdtdec.h |    1 +
>  lib/fdtdec.c     |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/fdtdec.h b/include/fdtdec.h
> index 77f244f..cca9be1 100644
> --- a/include/fdtdec.h
> +++ b/include/fdtdec.h
> @@ -81,6 +81,7 @@ enum fdt_compat_id {
>         COMPAT_SAMSUNG_EXYNOS_EHCI,     /* Exynos EHCI controller */
>         COMPAT_SAMSUNG_EXYNOS_USB_PHY,  /* Exynos phy controller for usb2.0 */
>         COMPAT_MAXIM_MAX77686_PMIC,     /* MAX77686 PMIC */
> +       COMPAT_SAMSUNG_EXYNOS5_SERIAL,  /* Exynos5 UART */
>
>         COMPAT_COUNT,
>  };
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index 3ae348d..ec19c4b 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -56,6 +56,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>         COMPAT(SAMSUNG_EXYNOS_EHCI, "samsung,exynos-ehci"),
>         COMPAT(SAMSUNG_EXYNOS_USB_PHY, "samsung,exynos-usb-phy"),
>         COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
> +       COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos-uart"),

The kernel seems to have this:

	serial@12C00000 {
		compatible = "samsung,exynos4210-uart";
		reg = <0x12C00000 0x100>;
		interrupts = <0 51 0>;
	};

Should we use the same compatible string in U-Boot, or are you
planning the change the kernel?

Regards,
Simon

>  };
>
>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
> --
> 1.7.4.4
>
Rajeshwari Birje - March 1, 2013, 6:14 a.m.
Hi Simon,

Thank you for comments.

On Thu, Feb 28, 2013 at 6:49 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi
>
> On Tue, Feb 26, 2013 at 10:01 PM, Rajeshwari Shinde
> <rajeshwari.s@samsung.com> wrote:
>> Add required compatible information for s5p serial driver
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>>  include/fdtdec.h |    1 +
>>  lib/fdtdec.c     |    1 +
>>  2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/fdtdec.h b/include/fdtdec.h
>> index 77f244f..cca9be1 100644
>> --- a/include/fdtdec.h
>> +++ b/include/fdtdec.h
>> @@ -81,6 +81,7 @@ enum fdt_compat_id {
>>         COMPAT_SAMSUNG_EXYNOS_EHCI,     /* Exynos EHCI controller */
>>         COMPAT_SAMSUNG_EXYNOS_USB_PHY,  /* Exynos phy controller for usb2.0 */
>>         COMPAT_MAXIM_MAX77686_PMIC,     /* MAX77686 PMIC */
>> +       COMPAT_SAMSUNG_EXYNOS5_SERIAL,  /* Exynos5 UART */
>>
>>         COMPAT_COUNT,
>>  };
>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>> index 3ae348d..ec19c4b 100644
>> --- a/lib/fdtdec.c
>> +++ b/lib/fdtdec.c
>> @@ -56,6 +56,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>>         COMPAT(SAMSUNG_EXYNOS_EHCI, "samsung,exynos-ehci"),
>>         COMPAT(SAMSUNG_EXYNOS_USB_PHY, "samsung,exynos-usb-phy"),
>>         COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
>> +       COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos-uart"),
>
> The kernel seems to have this:
>
>         serial@12C00000 {
>                 compatible = "samsung,exynos4210-uart";
>                 reg = <0x12C00000 0x100>;
>                 interrupts = <0 51 0>;
>         };
>
> Should we use the same compatible string in U-Boot, or are you
> planning the change the kernel?
Okay in that case will keep the compatible string as "samsung,exynos4210-uart".
>
> Regards,
> Simon
>
>>  };
>>
>>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
>> --
>> 1.7.4.4
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/include/fdtdec.h b/include/fdtdec.h
index 77f244f..cca9be1 100644
--- a/include/fdtdec.h
+++ b/include/fdtdec.h
@@ -81,6 +81,7 @@  enum fdt_compat_id {
 	COMPAT_SAMSUNG_EXYNOS_EHCI,	/* Exynos EHCI controller */
 	COMPAT_SAMSUNG_EXYNOS_USB_PHY,	/* Exynos phy controller for usb2.0 */
 	COMPAT_MAXIM_MAX77686_PMIC,	/* MAX77686 PMIC */
+	COMPAT_SAMSUNG_EXYNOS5_SERIAL,	/* Exynos5 UART */
 
 	COMPAT_COUNT,
 };
diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index 3ae348d..ec19c4b 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -56,6 +56,7 @@  static const char * const compat_names[COMPAT_COUNT] = {
 	COMPAT(SAMSUNG_EXYNOS_EHCI, "samsung,exynos-ehci"),
 	COMPAT(SAMSUNG_EXYNOS_USB_PHY, "samsung,exynos-usb-phy"),
 	COMPAT(MAXIM_MAX77686_PMIC, "maxim,max77686_pmic"),
+	COMPAT(SAMSUNG_EXYNOS5_SERIAL, "samsung,exynos-uart"),
 };
 
 const char *fdtdec_get_compatible(enum fdt_compat_id id)