Patchwork [U-Boot] nand: adjust erase/read/write partition/chip size for bad blocks

login
register
mail settings
Submitter Harvey Chapman
Date Feb. 27, 2013, 3:21 a.m.
Message ID <1361935287-62872-1-git-send-email-hchapman@3gfp.com>
Download mbox | patch
Permalink /patch/223488/
State Accepted
Delegated to: Scott Wood
Headers show

Comments

Harvey Chapman - Feb. 27, 2013, 3:21 a.m.
Adjust the sizes calculated for whole partition/chip operations by
removing the size of bad blocks so we don't try to erase/read/write
past a partition/chip boundary.

Signed-off-by: Harvey Chapman <hchapman@3gfp.com>
---
 common/cmd_nand.c |   35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
Scott Wood - May 22, 2013, 9:36 p.m.
On Tue, Feb 26, 2013 at 05:21:27PM -0000, Harvey Chapman wrote:
> Adjust the sizes calculated for whole partition/chip operations by
> removing the size of bad blocks so we don't try to erase/read/write
> past a partition/chip boundary.
> 
> Signed-off-by: Harvey Chapman <hchapman@3gfp.com>
> 
> ---
> common/cmd_nand.c |   35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

Applied to u-boot-nand-flash...

> +			/* size is unspecified */
> +			if (argc < 5)
> +				adjust_size_for_badblocks(&rwsize, off, dev);

...after fixing this to be &size rather than &rwsize.

-Scott
Scott Wood - May 22, 2013, 9:42 p.m.
On 05/22/2013 04:36:41 PM, Scott Wood wrote:
> On Tue, Feb 26, 2013 at 05:21:27PM -0000, Harvey Chapman wrote:
> > Adjust the sizes calculated for whole partition/chip operations by
> > removing the size of bad blocks so we don't try to erase/read/write
> > past a partition/chip boundary.
> >
> > Signed-off-by: Harvey Chapman <hchapman@3gfp.com>
> >
> > ---
> > common/cmd_nand.c |   35 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> 
> Applied to u-boot-nand-flash...
> 
> > +			/* size is unspecified */
> > +			if (argc < 5)
> > +				adjust_size_for_badblocks(&rwsize, off,  
> dev);
> 
> ...after fixing this to be &size rather than &rwsize.

...and then noticed that the next patch in my queue was a resent  
version of this with that fixed. :-P

-Scott

Patch

diff --git a/common/cmd_nand.c b/common/cmd_nand.c
index 495610c..67d9b59 100644
--- a/common/cmd_nand.c
+++ b/common/cmd_nand.c
@@ -428,6 +428,31 @@  static int raw_access(nand_info_t *nand, ulong addr, loff_t off, ulong count,
 	return ret;
 }
 
+/* Adjust a chip/partition size down for bad blocks so we don't
+ * read/write/erase past the end of a chip/partition by accident.
+ */
+static void adjust_size_for_badblocks(loff_t *size, loff_t offset, int dev)
+{
+	/* We grab the nand info object here fresh because this is usually
+	 * called after arg_off_size() which can change the value of dev.
+	 */
+	nand_info_t *nand = &nand_info[dev];
+	loff_t maxoffset = offset + *size;
+	int badblocks = 0;
+
+	/* count badblocks in NAND from offset to offset + size */
+	for (; offset < maxoffset; offset += nand->erasesize) {
+		if (nand_block_isbad(nand, offset))
+			badblocks++;
+	}
+	/* adjust size if any bad blocks found */
+	if (badblocks) {
+		*size -= badblocks * nand->erasesize;
+		printf("size adjusted to 0x%llx (%d bad blocks)\n",
+		       (unsigned long long)*size, badblocks);
+	}
+}
+
 static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	int i, ret = 0;
@@ -524,6 +549,7 @@  static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		int scrub = !strncmp(cmd, "scrub", 5);
 		int spread = 0;
 		int args = 2;
+		int adjust_size = 0;
 		const char *scrub_warn =
 			"Warning: "
 			"scrub option will erase all factory set bad blocks!\n"
@@ -540,8 +566,10 @@  static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 				spread = 1;
 			} else if (!strcmp(&cmd[5], ".part")) {
 				args = 1;
+				adjust_size = 1;
 			} else if (!strcmp(&cmd[5], ".chip")) {
 				args = 0;
+				adjust_size = 1;
 			} else {
 				goto usage;
 			}
@@ -560,6 +588,10 @@  static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		if (arg_off_size(argc - o, argv + o, &dev, &off, &size) != 0)
 			return 1;
 
+		/* size is unspecified */
+		if (adjust_size && !scrub)
+			adjust_size_for_badblocks(&size, off, dev);
+
 		nand = &nand_info[dev];
 
 		memset(&opts, 0, sizeof(opts));
@@ -644,6 +676,9 @@  static int do_nand(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 						&off, &size) != 0)
 				return 1;
 
+			/* size is unspecified */
+			if (argc < 5)
+				adjust_size_for_badblocks(&rwsize, off, dev);
 			rwsize = size;
 		}