Patchwork [V2,1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

login
register
mail settings
Submitter Joseph Lo
Date Feb. 27, 2013, 2:27 a.m.
Message ID <1361932063-13263-1-git-send-email-josephl@nvidia.com>
Download mbox | patch
Permalink /patch/223463/
State Accepted, archived
Headers show

Comments

Joseph Lo - Feb. 27, 2013, 2:27 a.m.
The PMC HW is not 100% compatible across all Tegra series. We need to
specify each of them in the DT match table.

Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
V2:
* fix the typo and the chip order in DT match table
---
 arch/arm/mach-tegra/pmc.c | 2 ++
 1 file changed, 2 insertions(+)
Stephen Warren - Feb. 27, 2013, 5:44 p.m.
On 02/26/2013 07:27 PM, Joseph Lo wrote:
> The PMC HW is not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.

Seems reasonable. I plan to apply for 3.10 when I can.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - March 6, 2013, 9:45 p.m.
On 02/26/2013 07:27 PM, Joseph Lo wrote:
> The PMC HW is not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.

I have applied these two patches to Tegra's for-3.10/cleanup branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index d4fdb5f..5d79d34 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -36,6 +36,8 @@  static inline void tegra_pmc_writel(u32 val, u32 reg)
 
 #ifdef CONFIG_OF
 static const struct of_device_id matches[] __initconst = {
+	{ .compatible = "nvidia,tegra114-pmc" },
+	{ .compatible = "nvidia,tegra30-pmc" },
 	{ .compatible = "nvidia,tegra20-pmc" },
 	{ }
 };