From patchwork Wed Feb 27 00:37:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: patch to fix constant math - third patch - what is left for next stage 1 From: Kenneth Zadeck X-Patchwork-Id: 223438 Message-Id: <512D5535.4010908@naturalbridge.com> To: Richard Biener , Richard Sandiford , Mike Stump , gcc-patches , Ian Lance Taylor , Kenneth Zadeck Date: Tue, 26 Feb 2013 19:37:09 -0500 the original patch 3 was accepted and committed. These were subsequent comments. This could likely be just checked in the next stage 1 without approval. 2013-2-26 Kenneth Zadeck * combine.c (try_combine): Removed useless assert. * cselib.c (rtx_equal_for_cselib_1): Removed unnecessary parens. diff --git a/gcc/combine.c b/gcc/combine.c index acb7421..98ca4a8 100644 --- a/gcc/combine.c +++ b/gcc/combine.c @@ -2635,11 +2635,6 @@ try_combine (rtx i3, rtx i2, rtx i1, rtx i0, int *new_direct_jump_p, int offset = -1; int width = 0; - /* There are not explicit tests to make sure that this is not a - float, but there is code here that would not be correct if it - was. */ - gcc_assert (GET_MODE_CLASS (GET_MODE (SET_SRC (temp))) != MODE_FLOAT); - if (GET_CODE (dest) == ZERO_EXTRACT) { if (CONST_INT_P (XEXP (dest, 1)) diff --git a/gcc/cselib.c b/gcc/cselib.c index f2021b9..dcad9741 100644 --- a/gcc/cselib.c +++ b/gcc/cselib.c @@ -1026,7 +1026,7 @@ rtx_equal_for_cselib_1 (rtx x, rtx y, enum machine_mode memmode) static rtx wrap_constant (enum machine_mode mode, rtx x) { - if ((!CONST_SCALAR_INT_P (x)) && GET_CODE (x) != CONST_FIXED) + if (!CONST_SCALAR_INT_P (x) && GET_CODE (x) != CONST_FIXED) return x; gcc_assert (mode != VOIDmode); return gen_rtx_CONST (mode, x);