From patchwork Wed Feb 27 00:37:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kenneth Zadeck X-Patchwork-Id: 223438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id AA7572C0086 for ; Wed, 27 Feb 2013 11:37:31 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362530252; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=fm1evuA 2o7eGijYc8G2lByibYSA=; b=ki/1DRaP3xTwy0JHszBvSn3rr8aCfoYd53tvEIU ZAx5r2Fm1L2/AAFC3ZSB6ccviyI7jBVKEp4+NK+B+5YTXcsTaL0Rrhno9K7z6T1I 3GYo0ylw5aQalnf3tZviDMUIahhN9iFeGzcUo6LZmQ9SpCcCF4a4DdgsYgPR/49U 8o8g= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:X-Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:X-Gm-Message-State:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=DbyMqP9N4tn2e1ZrkRdkb/UPNoTCMiIAdQzzc4Di3kd00uwIHCJ8dOtT7Cf9vm n5CN12WxucrFANM3RSNkV9zuW6aSnHCg1pFocRlyu4/0MRKmEroDNunVsObwbNNZ jb2duw4W61d9cMRJLFPDTo73e0Bk8HWKiELvpGWq/OH6Y=; Received: (qmail 9947 invoked by alias); 27 Feb 2013 00:37:18 -0000 Received: (qmail 9889 invoked by uid 22791); 27 Feb 2013 00:37:16 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-gh0-f181.google.com (HELO mail-gh0-f181.google.com) (209.85.160.181) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 00:37:11 +0000 Received: by mail-gh0-f181.google.com with SMTP id y8so818201ghb.40 for ; Tue, 26 Feb 2013 16:37:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:x-gm-message-state; bh=mTAxV5r2gxX2FGcOq7sKW0Yxx8xeMrI7r8SpERhgP/Y=; b=idxUWWWn52enAVKQMjOhVYzb+GSuXCVzRg1sYCBx2X1jK2LNRTKA1q7zcONIU5KLzu Po8IXMLuvj6nQ3WtCxkXyeL7Dgqot1SY0ZXgtzjbQbvCb9NCgnjjKc6v+rN7rsOFizLM E73F9NoGqxhuL89vQztsfQ5IpEI+ru0LJALVshNeuxUWjk+AWyoHbhQgtjDR2I23ZbPc ebzoNChGRou/x9tzBXBPZyFuqjChQCQAt0tx6x4Jv7oJgdhPbLqrXgAh5QLAYq5RQ8I/ lOTNhJQG8VtgQ5Cx44SIalA8yUlpt0Di40uOMloiJIHyKkrSUwxz8/MseAmzwGsUarcY AU0g== X-Received: by 10.236.138.42 with SMTP id z30mr209173yhi.101.1361925431247; Tue, 26 Feb 2013 16:37:11 -0800 (PST) Received: from [192.168.1.10] (pool-108-46-172-132.nycmny.fios.verizon.net. [108.46.172.132]) by mx.google.com with ESMTPS id w2sm4776916yhh.7.2013.02.26.16.37.10 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Feb 2013 16:37:10 -0800 (PST) Message-ID: <512D5535.4010908@naturalbridge.com> Date: Tue, 26 Feb 2013 19:37:09 -0500 From: Kenneth Zadeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: Richard Biener , Richard Sandiford , Mike Stump , gcc-patches , Ian Lance Taylor , Kenneth Zadeck Subject: patch to fix constant math - third patch - what is left for next stage 1 X-Gm-Message-State: ALoCoQnio5DSd48jvaHo6E1ljEXfdqQ0uVA7DjAdWFStRFuuQMjIMEh+WcEvQizEo4MhlTrjAcYR Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org the original patch 3 was accepted and committed. These were subsequent comments. This could likely be just checked in the next stage 1 without approval. 2013-2-26 Kenneth Zadeck * combine.c (try_combine): Removed useless assert. * cselib.c (rtx_equal_for_cselib_1): Removed unnecessary parens. diff --git a/gcc/combine.c b/gcc/combine.c index acb7421..98ca4a8 100644 --- a/gcc/combine.c +++ b/gcc/combine.c @@ -2635,11 +2635,6 @@ try_combine (rtx i3, rtx i2, rtx i1, rtx i0, int *new_direct_jump_p, int offset = -1; int width = 0; - /* There are not explicit tests to make sure that this is not a - float, but there is code here that would not be correct if it - was. */ - gcc_assert (GET_MODE_CLASS (GET_MODE (SET_SRC (temp))) != MODE_FLOAT); - if (GET_CODE (dest) == ZERO_EXTRACT) { if (CONST_INT_P (XEXP (dest, 1)) diff --git a/gcc/cselib.c b/gcc/cselib.c index f2021b9..dcad9741 100644 --- a/gcc/cselib.c +++ b/gcc/cselib.c @@ -1026,7 +1026,7 @@ rtx_equal_for_cselib_1 (rtx x, rtx y, enum machine_mode memmode) static rtx wrap_constant (enum machine_mode mode, rtx x) { - if ((!CONST_SCALAR_INT_P (x)) && GET_CODE (x) != CONST_FIXED) + if (!CONST_SCALAR_INT_P (x) && GET_CODE (x) != CONST_FIXED) return x; gcc_assert (mode != VOIDmode); return gen_rtx_CONST (mode, x);