Patchwork Pass LDFLAGS when building libgcc

login
register
mail settings
Submitter Ludovic =?iso-8859-1?Q?Court=E8s?=
Date Feb. 26, 2013, 10:07 p.m.
Message ID <87txoy20h7.fsf@gnu.org>
Download mbox | patch
Permalink /patch/223415/
State New
Headers show

Comments

Ludovic =?iso-8859-1?Q?Court=E8s?= - Feb. 26, 2013, 10:07 p.m.
Ian Lance Taylor <iant@google.com> skribis:

> On Tue, Feb 26, 2013 at 11:28 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>>
>> In FLAGS_TO_PASS, libgcc/Makefile.in refers to $(LDFLAGS), but that
>> variable is never set, so empty in practice.  I believe This patches
>> fixes that.
>
> This is OK with a ChangeLog entry.

libgcc/ChangeLog:

2013-02-26  Ludovic Courtès  <ludo@gnu.org>

	* Makefile.in (LDFLAGS): New variable.
Thanks,
Ludo’.
Dave Korn - Feb. 27, 2013, 5:23 p.m.
On 26/02/2013 22:07, Ludovic Courtès wrote:

> 	* Makefile.in (LDFLAGS): New variable.

  "Import from automake" might be more informative.

    cheers,
      DaveK
Ludovic =?iso-8859-1?Q?Court=E8s?= - Feb. 27, 2013, 7:53 p.m.
Dave Korn <dave.korn.cygwin@gmail.com> skribis:

> On 26/02/2013 22:07, Ludovic Courtès wrote:
>
>> 	* Makefile.in (LDFLAGS): New variable.
>
>   "Import from automake" might be more informative.

Automake has nothing to do with that.

Ludo’.
Dave Korn - Feb. 28, 2013, 12:26 a.m.
On 27/02/2013 19:53, Ludovic Courtès wrote:
> Dave Korn skribis:
> 
>> On 26/02/2013 22:07, Ludovic Courtès wrote:
>>
>>> 	* Makefile.in (LDFLAGS): New variable.
>>   "Import from automake" might be more informative.
> 
> Automake has nothing to do with that.

  Thinko on my part.  It's autoconf (via the generated configure script) that
does those substitutions.

    cheers,
      DaveK

Patch

--- gcc-4.7.2/libgcc/Makefile.in~	2012-09-05 14:19:47.000000000 +0200
+++ gcc-4.7.2/libgcc/Makefile.in	2013-02-26 20:26:15.000000000 +0100
@@ -72,6 +72,7 @@  AR_FLAGS = rc
 
 CC = @CC@
 CFLAGS = @CFLAGS@
+LDFLAGS = @LDFLAGS@
 RANLIB = @RANLIB@
 LN_S = @LN_S@