Patchwork [RFC] core: Add ioctls to control device unicast hw addresses

login
register
mail settings
Submitter Vlad Yasevich
Date Feb. 26, 2013, 4:59 p.m.
Message ID <1361897970-1728-1-git-send-email-vyasevic@redhat.com>
Download mbox | patch
Permalink /patch/223353/
State RFC
Delegated to: David Miller
Headers show

Comments

Vlad Yasevich - Feb. 26, 2013, 4:59 p.m.
There is currently a way to manage the multicast HW address list
through SIOCADDMULTI/SIOCDELMULTI, but there is no way to
consistently manage the unicast list.  Some drivers provide
FDB based interface, but that depends on driver configuration
in almost every case.

This patch provides 2 new ioctls that allow on to add/delete
unicast HW address on a device.

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
 include/uapi/linux/sockios.h |    4 ++++
 net/core/dev_ioctl.c         |   22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
David Miller - Feb. 26, 2013, 5:43 p.m.
No new ioctls please, extend the netlink interfaces as necessary
instead.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
index 7997a50..442360e 100644
--- a/include/uapi/linux/sockios.h
+++ b/include/uapi/linux/sockios.h
@@ -127,6 +127,10 @@ 
 /* hardware time stamping: parameters in linux/net_tstamp.h */
 #define SIOCSHWTSTAMP   0x89b0
 
+/* Device address management */
+#define SIOCADDHWADDR	0x89c0		/* Unicast address list */
+#define SIOCDELHWADDR	0x8932
+
 /* Device private ioctl calls */
 
 /*
diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
index 6cc0481..d84f6f9 100644
--- a/net/core/dev_ioctl.c
+++ b/net/core/dev_ioctl.c
@@ -314,6 +314,26 @@  static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
 		ifr->ifr_newname[IFNAMSIZ-1] = '\0';
 		return dev_change_name(dev, ifr->ifr_newname);
 
+	case SIOCADDHWADDR:
+		if (!ops->ndo_set_rx_mode ||
+		    ifr->ifr_hwaddr.sa_family != AF_UNSPEC)
+			return -EINVAL;
+		if (!netif_device_present(dev))
+			return -ENODEV;
+		if (!is_unicast_ether_addr(addr))
+			return -EINVAL;
+		return dev_uc_add_excl(dev, ifr->ifr_hwaddr.sa_data);
+
+	case SIOCDELHWADDR:
+		if (!ops->ndo_set_rx_mode ||
+		    ifr->ifr_hwaddr.sa_family != AF_UNSPEC)
+			return -EINVAL;
+		if (!netif_device_present(dev))
+			return -ENODEV;
+		if (!is_unicast_ether_addr(addr))
+			return -EINVAL;
+		return dev_uc_del(dev, ifr->ifr_hwaddr.sa_data);
+
 	case SIOCSHWTSTAMP:
 		err = net_hwtstamp_validate(ifr);
 		if (err)
@@ -532,6 +552,8 @@  int dev_ioctl(struct net *net, unsigned int cmd, void __user *arg)
 	case SIOCBRADDIF:
 	case SIOCBRDELIF:
 	case SIOCSHWTSTAMP:
+	case SIOCADDHWADDR:
+	case SIOCDELHWADDR:
 		if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
 			return -EPERM;
 		/* fall through */