Patchwork [3.5.y.z,extended,stable] Patch "ALSA: ali5451: remove irq enabling in pointer callback" has been added to staging queue

mail settings
Submitter Luis Henriques
Date Feb. 26, 2013, 4:13 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/223307/
State New
Headers show


Luis Henriques - Feb. 26, 2013, 4:13 p.m.
This is a note to let you know that I have just added a patch titled

    ALSA: ali5451: remove irq enabling in pointer callback

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From 1010b955961202be4ff0dd1fd1994c690876915e Mon Sep 17 00:00:00 2001
From: Denis Efremov <>
Date: Mon, 11 Feb 2013 19:49:48 +0400
Subject: [PATCH] ALSA: ali5451: remove irq enabling in pointer callback

commit dacae5a19b4cbe1b5e3a86de23ea74cbe9ec9652 upstream.

snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.

Found by Linux Driver Verification project (

Signed-off-by: Denis Efremov <>
Signed-off-by: Takashi Iwai <>
Signed-off-by: Luis Henriques <>
 sound/pci/ali5451/ali5451.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
index 9dfc27b..2c4dd6b 100644
--- a/sound/pci/ali5451/ali5451.c
+++ b/sound/pci/ali5451/ali5451.c
@@ -1435,7 +1435,7 @@  static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)

 	if (!pvoice->running) {
-		spin_unlock_irq(&codec->reg_lock);
+		spin_unlock(&codec->reg_lock);
 		return 0;
 	outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));