Patchwork [3.5.y.z,extended,stable] Patch " Eliminate Perl warning" has been added to staging queue

mail settings
Submitter Luis Henriques
Date Feb. 26, 2013, 4:13 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/223299/
State New
Headers show


Luis Henriques - Feb. 26, 2013, 4:13 p.m.
This is a note to let you know that I have just added a patch titled Eliminate Perl warning

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From ad189263dca20732c250e4ce15935792016c6abe Mon Sep 17 00:00:00 2001
From: "H. Peter Anvin" <>
Date: Thu, 7 Feb 2013 17:14:08 -0800
Subject: [PATCH] Eliminate Perl warning

commit 63a3f603413ffe82ad775f2d62a5afff87fd94a0 upstream.

defined(@array) is deprecated in Perl and gives off a warning.
Restructure the code to remove that warning.

[ hpa: it would be interesting to revert to the timeconst.bc script.
  It appears that the failures reported by akpm during testing of
  that script was due to a known broken version of make, not a problem
  with bc.  The Makefile rules could probably be restructured to avoid
  the make bug, or it is probably old enough that it doesn't matter. ]

Reported-by: Andi Kleen <>
Signed-off-by: H. Peter Anvin <>
Cc: Andrew Morton <>
Signed-off-by: Luis Henriques <>
 kernel/ | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)



diff --git a/kernel/ b/kernel/
index eb51d76..3f42652 100644
--- a/kernel/
+++ b/kernel/
@@ -369,10 +369,8 @@  if ($hz eq '--can') {
 		die "Usage: $0 HZ\n";

-	@val = @{$canned_values{$hz}};
-	if (!defined(@val)) {
-		@val = compute_values($hz);
-	}
+	$cv = $canned_values{$hz};
+	@val = defined($cv) ? @$cv : compute_values($hz);
 	output($hz, @val);
 exit 0;