Patchwork [3.5.y.z,extended,stable] Patch "rc: unlock on error in show_protocols()" has been added to staging queue

mail settings
Submitter Luis Henriques
Date Feb. 26, 2013, 4:12 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/223262/
State New
Headers show


Luis Henriques - Feb. 26, 2013, 4:12 p.m.
This is a note to let you know that I have just added a patch titled

    rc: unlock on error in show_protocols()

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From c6d3a35a81bd8320fd91b55271d238543d4cd53f Mon Sep 17 00:00:00 2001
From: Dan Carpenter <>
Date: Tue, 27 Nov 2012 13:35:09 -0300
Subject: [PATCH] rc: unlock on error in show_protocols()

commit 30ebc5e44d057a1619ad63fe32c8c1670c37c4b8 upstream.

We recently introduced a new return -ENODEV in this function but we need
to unlock before returning.

[ found two patches with the same fix. Merged SOB's/acks into one patch]
Acked-by: Herton R. Krzesinski <>
Signed-off-by: Dan Carpenter <>
Signed-off-by: Douglas Bagnall <>

Signed-off-by: Mauro Carvalho Chehab <>
Signed-off-by: Luis Henriques <>
 drivers/media/rc/rc-main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)



diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index cabc19c..cec1f8c 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -778,8 +778,10 @@  static ssize_t show_protocols(struct device *device,
 	} else if (dev->raw) {
 		enabled = dev->raw->enabled_protocols;
 		allowed = ir_raw_get_allowed_protocols();
-	} else
+	} else {
+		mutex_unlock(&dev->lock);
 		return -ENODEV;
+	}

 	IR_dprintk(1, "allowed - 0x%llx, enabled - 0x%llx\n",
 		   (long long)allowed,