Patchwork [testsuite] Remove dg-excess-errors in gcc.dg/inline_[34].c and unroll_[234].c

login
register
mail settings
Submitter Dominique Dhumieres
Date Feb. 26, 2013, 10:30 a.m.
Message ID <20130226103050.C52B93BE1D@mailhost.lps.ens.fr>
Download mbox | patch
Permalink /patch/223189/
State New
Headers show

Comments

Dominique Dhumieres - Feb. 26, 2013, 10:30 a.m.
The following tests XPASS on i?86-*-linux* and x86_64-*-linux* (see, 
e.g., http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg02923.html )

XPASS: gcc.dg/inline_3.c (test for excess errors)
XPASS: gcc.dg/inline_4.c (test for excess errors)
XPASS: gcc.dg/unroll_2.c (test for excess errors)
XPASS: gcc.dg/unroll_3.c (test for excess errors)
XPASS: gcc.dg/unroll_4.c (test for excess errors)

The following patch fixes this to remove the noise.  In addition I do not
see why this tests should be restricted to i?86-*-linux* and
x86_64-*-linux* (the other tests inline_[12].c and unroll_[15] have no
restrictions).  Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10.

Ok for mainline? If yes, could someone commit the patch since I don't have 
write access?

	Dominique


2013-02-26  Dominique d'Humieres  <dominiq@lps.ens.fr>

	* gcc.dg/inline_3.c: Remove target and dg-excess-errors.
	* gcc.dg/inline_4.c: Likewise.
	* gcc.dg/unroll_2.c: Likewise.
	* gcc.dg/unroll_3.c: Likewise.
	* gcc.dg/unroll_4.c: Likewise.
Rainer Orth - March 11, 2013, 10:14 a.m.
dominiq@lps.ens.fr (Dominique Dhumieres) writes:

> The following tests XPASS on i?86-*-linux* and x86_64-*-linux* (see, 
> e.g., http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg02923.html )
>
> XPASS: gcc.dg/inline_3.c (test for excess errors)
> XPASS: gcc.dg/inline_4.c (test for excess errors)
> XPASS: gcc.dg/unroll_2.c (test for excess errors)
> XPASS: gcc.dg/unroll_3.c (test for excess errors)
> XPASS: gcc.dg/unroll_4.c (test for excess errors)
>
> The following patch fixes this to remove the noise.  In addition I do not
> see why this tests should be restricted to i?86-*-linux* and
> x86_64-*-linux* (the other tests inline_[12].c and unroll_[15] have no
> restrictions).  Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10.
>
> Ok for mainline? If yes, could someone commit the patch since I don't have 
> write access?

I've now tested the patch on x86_64-unknown-linux-gnu and
i686-unknown-linux-gnu where it removes the XPASSes (thus less testsuite
noise), and on {i386-pc,sparc-sun}-solaris2.{9,10,11} where the tests
pass, too.

Unless the release managers object, I plan to commit it later today.

Thanks and sorry for the delay.

	Rainer

Patch

--- ../_clean/gcc/testsuite/gcc.dg/inline_3.c	2011-06-21 09:13:05.000000000 +0200
+++ gcc/testsuite/gcc.dg/inline_3.c	2013-02-03 19:25:05.000000000 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile   { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo,foo2 -fdisable-ipa-inline -Wno-attributes" } */
 int g;
 __attribute__((always_inline)) void bar (void)
@@ -20,4 +20,3 @@  int foo2 (void)
 
 /* { dg-final { scan-tree-dump-times "bar" 5 "optimized" } } */
 /* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/inline_4.c	2011-06-21 09:13:05.000000000 +0200
+++ gcc/testsuite/gcc.dg/inline_4.c	2013-02-03 19:25:20.000000000 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile  { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo2 -fdisable-ipa-inline -Wno-attributes" } */
 int g;
 __attribute__((always_inline)) void bar (void)
@@ -20,4 +20,3 @@  int foo2 (void)
 
 /* { dg-final { scan-tree-dump-times "bar" 4 "optimized" } } */
 /* { dg-final { cleanup-tree-dump "optimized" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_2.c	2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_2.c	2013-02-03 19:25:43.000000000 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile  { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll=foo -fdisable-tree-cunrolli=foo -fenable-rtl-loop2_unroll" } */
 
 unsigned a[100], b[100];
@@ -30,4 +30,3 @@  int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_3.c	2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_3.c	2013-02-03 19:25:55.000000000 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile  { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll -fdisable-tree-cunrolli -fenable-rtl-loop2_unroll=foo" } */
 
 unsigned a[100], b[100];
@@ -30,4 +30,3 @@  int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */
--- ../_clean/gcc/testsuite/gcc.dg/unroll_4.c	2013-01-03 10:46:27.000000000 +0100
+++ gcc/testsuite/gcc.dg/unroll_4.c	2013-02-03 19:26:10.000000000 +0100
@@ -1,4 +1,4 @@ 
-/* { dg-do compile  { target i?86-*-linux* x86_64-*-linux* } } */
+/* { dg-do compile } */
 /* { dg-options "-O2 -fdump-rtl-loop2_unroll -fno-peel-loops -fdisable-tree-cunroll -fdisable-tree-cunrolli -fenable-rtl-loop2_unroll=foo2" } */
 
 unsigned a[100], b[100];
@@ -30,4 +30,3 @@  int foo2(void)
 
 /* { dg-final { scan-rtl-dump-times "Turned loop into non-loop; it never loops" 1 "loop2_unroll" } } */
 /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */
-/* { dg-excess-errors "extra notes" } */