Patchwork [1/2] ARM: tegra: pmc: add specific compatible DT string for Tegra30 and Tegra114

login
register
mail settings
Submitter Joseph Lo
Date Feb. 26, 2013, 9:58 a.m.
Message ID <1361872727-4388-1-git-send-email-josephl@nvidia.com>
Download mbox | patch
Permalink /patch/223159/
State Superseded, archived
Headers show

Comments

Joseph Lo - Feb. 26, 2013, 9:58 a.m.
The PMC HW dose not 100% compatible across all Tegra series. We need to
specify each of them in the DT match table.

Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
 arch/arm/mach-tegra/pmc.c | 2 ++
 1 file changed, 2 insertions(+)
Stephen Warren - Feb. 26, 2013, 4:29 p.m.
On 02/26/2013 02:58 AM, Joseph Lo wrote:
> The PMC HW dose not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.

> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c

>  static const struct of_device_id matches[] __initconst = {
>  	{ .compatible = "nvidia,tegra20-pmc" },
> +	{ .compatible = "nvidia,tegra30-pmc" },
> +	{ .compatible = "nvidia,tegra114-pmc" },
>  	{ }
>  };

Those should be listed in order of most recent device through least
recent device, i.e. in the opposite order.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov - Feb. 26, 2013, 9 p.m.
Hello.

On 26-02-2013 13:58, Joseph Lo wrote:

    Almost the same mistake.

> The PMC HW dose

    s/dose/is/

> not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.

> Signed-off-by: Joseph Lo <josephl@nvidia.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index d4fdb5f..1b5a908 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -37,6 +37,8 @@  static inline void tegra_pmc_writel(u32 val, u32 reg)
 #ifdef CONFIG_OF
 static const struct of_device_id matches[] __initconst = {
 	{ .compatible = "nvidia,tegra20-pmc" },
+	{ .compatible = "nvidia,tegra30-pmc" },
+	{ .compatible = "nvidia,tegra114-pmc" },
 	{ }
 };
 #endif