Patchwork [4/5] ext4: remove unnecessary wait for extent conversion in ext4_fallocate()

login
register
mail settings
Submitter Dmitri Monakho
Date Feb. 25, 2013, 4:07 p.m.
Message ID <1361808463-25471-4-git-send-email-dmonakhov@openvz.org>
Download mbox | patch
Permalink /patch/222954/
State Accepted
Headers show

Comments

Dmitri Monakho - Feb. 25, 2013, 4:07 p.m.
From: Jan Kara <jack@suse.cz>

Now that we don't merge uninitialized extents anymore,
ext4_fallocate() is free to operate on the inode while there are still
some extent conversions pending - it won't disturb them in any way.

Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Reviewed-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/extents.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 78c2a91..c89e850 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4391,8 +4391,6 @@  long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
 	if (len <= EXT_UNINIT_MAX_LEN << blkbits)
 		flags |= EXT4_GET_BLOCKS_NO_NORMALIZE;
 
-	/* Prevent race condition between unwritten */
-	ext4_flush_unwritten_io(inode);
 retry:
 	while (ret >= 0 && ret < max_blocks) {
 		map.m_lblk = map.m_lblk + ret;