From patchwork Mon Feb 25 15:55:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 222947 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 003AC2C02BF for ; Tue, 26 Feb 2013 02:55:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759932Ab3BYPzV (ORCPT ); Mon, 25 Feb 2013 10:55:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54881 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759868Ab3BYPzP (ORCPT ); Mon, 25 Feb 2013 10:55:15 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8884DA51B6; Mon, 25 Feb 2013 16:55:14 +0100 (CET) Received: by quack.suse.cz (Postfix, from userid 1000) id CF1EA2067D; Mon, 25 Feb 2013 16:55:12 +0100 (CET) From: Jan Kara To: Ted Tso Cc: linux-ext4@vger.kernel.org, Jan Kara Subject: [PATCH 2/4] libext2fs: Fix return value in ext2fs_test_block_bitmap_range2() Date: Mon, 25 Feb 2013 16:55:06 +0100 Message-Id: <1361807708-15871-3-git-send-email-jack@suse.cz> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1361807708-15871-1-git-send-email-jack@suse.cz> References: <1361807708-15871-1-git-send-email-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We used return without a return value in ext2fs_test_block_bitmap_range2() despite the fuction returns int. Signed-off-by: Jan Kara --- lib/ext2fs/gen_bitmap64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/ext2fs/gen_bitmap64.c b/lib/ext2fs/gen_bitmap64.c index 42a97d4..44ac499 100644 --- a/lib/ext2fs/gen_bitmap64.c +++ b/lib/ext2fs/gen_bitmap64.c @@ -658,7 +658,7 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap, if ((block < bmap->start) || (block+num-1 > bmap->end)) { ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_TEST, block, bmap->description); - return; + return EINVAL; } return bmap->bitmap_ops->test_clear_bmap_extent(bmap, block, num);