From patchwork Sun Feb 24 22:05:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Syam Sidhardhan X-Patchwork-Id: 222798 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9EFC12C029C for ; Mon, 25 Feb 2013 09:06:04 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759109Ab3BXWGA (ORCPT ); Sun, 24 Feb 2013 17:06:00 -0500 Received: from mail-da0-f54.google.com ([209.85.210.54]:36409 "EHLO mail-da0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015Ab3BXWF6 (ORCPT ); Sun, 24 Feb 2013 17:05:58 -0500 Received: by mail-da0-f54.google.com with SMTP id p1so582340dad.13 for ; Sun, 24 Feb 2013 14:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=zTeXEbT/aDJDjUfkrhfEP3fcFC9+LTpqGNaaPUj8yLo=; b=iutMkjxfFtMrJCVK0x/Yfc/98JAwXutpIfWClSi6TImLumQFDS/NQuGNY5aaUSTEOo ZXDfwyxKc8M4JMv8w1idnoLE5xDY91UJlv/ZT/BxoW67oSypVqRs63OktmzdAGtcj3q7 rsEJKCQMVoVpF2KB328hVdFtzTVjHO9CTZE/p/zf7DrrJxy9W0d1rLXaFdxSlSuDAxIp /FV5TOs4CWYOk7pU/OzoSvc+kR6MNyGWsCfFy7IT5jfSkeSO28mjEI3OJyuSbJWbpAex aFClNV/uSXWnrS1F7aI34pbLoAcUS+vHpFXin4PJcCrHdrgIOF+77SwX9xiQKaln2Qu+ gNZQ== X-Received: by 10.66.164.133 with SMTP id yq5mr15432615pab.160.1361743557843; Sun, 24 Feb 2013 14:05:57 -0800 (PST) Received: from localhost.localdomain ([27.7.134.34]) by mx.google.com with ESMTPS id ri1sm10342323pbc.16.2013.02.24.14.05.54 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Feb 2013 14:05:56 -0800 (PST) From: Syam Sidhardhan To: jussi.kivilinna@mbnet.fi, linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: syamsidhardh@gmail.com Subject: [PATCH] rndis_wlan: Remove redundant NULL check before kfree Date: Mon, 25 Feb 2013 03:35:43 +0530 Message-Id: <1361743543-27912-1-git-send-email-s.syam@samsung.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org kfree on a NULL pointer is a no-op. Signed-off-by: Syam Sidhardhan Acked-by: Jussi Kivilinna --- drivers/net/wireless/rndis_wlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index 525fd75..5f66b4e 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/wireless/rndis_wlan.c @@ -2839,8 +2839,7 @@ static void rndis_wlan_do_link_up_work(struct usbnet *usbdev) } else if (priv->infra_mode == NDIS_80211_INFRA_ADHOC) cfg80211_ibss_joined(usbdev->net, bssid, GFP_KERNEL); - if (info != NULL) - kfree(info); + kfree(info); priv->connected = true; memcpy(priv->bssid, bssid, ETH_ALEN);