Patchwork gstreamer: ALSA plugin requires threads support

login
register
mail settings
Submitter gilles.talis@gmail.com
Date Feb. 23, 2013, 7:04 a.m.
Message ID <1361603043-22539-1-git-send-email-gilles.talis@gmail.com>
Download mbox | patch
Permalink /patch/222704/
State Not Applicable
Headers show

Comments

gilles.talis@gmail.com - Feb. 23, 2013, 7:04 a.m.
Fixes:
http://autobuild.buildroot.org/results/2782b5ee6af25da9d49d9bc7b950dc2a92fb5bca

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/multimedia/gst-plugins-base/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
Peter Korsgaard - Feb. 23, 2013, 8:39 p.m.
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.org/results/2782b5ee6af25da9d49d9bc7b950dc2a92fb5bca

Isn't all of gstreamer heavily threaded?

 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
 Gilles> ---
 Gilles>  package/multimedia/gst-plugins-base/Config.in |    4 ++++
 Gilles>  1 file changed, 4 insertions(+)
gilles.talis@gmail.com - Feb. 25, 2013, 5:39 a.m.
2013/2/23 Peter Korsgaard <jacmet@uclibc.org>:
>>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:
>
>  Gilles> Fixes:
>  Gilles> http://autobuild.buildroot.org/results/2782b5ee6af25da9d49d9bc7b950dc2a92fb5bca
>
> Isn't all of gstreamer heavily threaded?

Yes, it is. But still it can be built with a toolchain that does not
provide threads support. Not sure if/how it works (could not test it
myself), but it builds. I just hit an issue in glib2 that I need to
look into a bit further.

Gilles.

Patch

diff --git a/package/multimedia/gst-plugins-base/Config.in b/package/multimedia/gst-plugins-base/Config.in
index af4fe8c..766a9ea 100644
--- a/package/multimedia/gst-plugins-base/Config.in
+++ b/package/multimedia/gst-plugins-base/Config.in
@@ -78,6 +78,10 @@  config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_ALSA
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_ALSA_LIB_PCM
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+
+comment "alsa support requires a toolchain with threads support enabled"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_OGG
 	bool "ogg (*.ogg audio/video)"