Patchwork [2/3] piix_pci: Use DEVICE() and ISA_BUS()

login
register
mail settings
Submitter David Woodhouse
Date Feb. 23, 2013, 12:40 a.m.
Message ID <1361580039-4459-3-git-send-email-dwmw2@infradead.org>
Download mbox | patch
Permalink /patch/222695/
State New
Headers show

Comments

David Woodhouse - Feb. 23, 2013, 12:40 a.m.
From: David Woodhouse <David.Woodhouse@intel.com>

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
 hw/piix_pci.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 6b69e26..19fc045 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -301,8 +301,7 @@  static PCIBus *i440fx_common_init(const char *device_name,
         pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq);
     }
     piix3->pic = pic;
-    *isa_bus = DO_UPCAST(ISABus, qbus,
-                         qdev_get_child_bus(&piix3->dev.qdev, "isa.0"));
+    *isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0"));
 
     *piix3_devfn = piix3->dev.devfn;
 
@@ -549,7 +548,7 @@  static int piix3_initfn(PCIDevice *dev)
 {
     PIIX3State *d = DO_UPCAST(PIIX3State, dev, dev);
 
-    isa_bus_new(&d->dev.qdev, pci_address_space_io(dev));
+    isa_bus_new(DEVICE(d), pci_address_space_io(dev));
 
     memory_region_init_io(&d->rcr_mem, &rcr_ops, d, "piix3-reset-control", 1);
     memory_region_add_subregion_overlap(pci_address_space_io(dev), RCR_IOPORT,