Patchwork [RESENT] configure: Create link to icon bitmap for out-of-tree builds

login
register
mail settings
Submitter Jan Kiszka
Date Feb. 22, 2013, 8:05 p.m.
Message ID <5127CF6D.2060104@siemens.com>
Download mbox | patch
Permalink /patch/222630/
State New
Headers show

Comments

Jan Kiszka - Feb. 22, 2013, 8:05 p.m.
This allows to pick up the icon when starting QEMU directly from an
out-of-tree build directory.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 configure |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Weil - Feb. 22, 2013, 8:28 p.m.
Am 22.02.2013 21:05, schrieb Jan Kiszka:
> This allows to pick up the icon when starting QEMU directly from an
> out-of-tree build directory.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 0eb25dd..265d8f7 100755
> --- a/configure
> +++ b/configure
> @@ -4342,6 +4342,7 @@ FILES="$FILES tests/tcg/lm32/Makefile po/Makefile"
>  FILES="$FILES pc-bios/optionrom/Makefile pc-bios/keymaps"
>  FILES="$FILES pc-bios/spapr-rtas/Makefile"
>  FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile"
> +FILES="$FILES pc-bios/qemu-icon.bmp"
>  for bios_file in \
>      $source_path/pc-bios/*.bin \
>      $source_path/pc-bios/*.aml \

I have a similar patch in my tree since two years (don't know
why I never sent it). The only difference is the order (I prefer
alphabetic order for such lines). If you decide to reorder,
you may add my Reviewed-by as well.

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Stefan Hajnoczi - March 8, 2013, 9:15 a.m.
On Fri, Feb 22, 2013 at 09:05:01PM +0100, Jan Kiszka wrote:
> This allows to pick up the icon when starting QEMU directly from an
> out-of-tree build directory.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/configure b/configure
index 0eb25dd..265d8f7 100755
--- a/configure
+++ b/configure
@@ -4342,6 +4342,7 @@  FILES="$FILES tests/tcg/lm32/Makefile po/Makefile"
 FILES="$FILES pc-bios/optionrom/Makefile pc-bios/keymaps"
 FILES="$FILES pc-bios/spapr-rtas/Makefile"
 FILES="$FILES roms/seabios/Makefile roms/vgabios/Makefile"
+FILES="$FILES pc-bios/qemu-icon.bmp"
 for bios_file in \
     $source_path/pc-bios/*.bin \
     $source_path/pc-bios/*.aml \