Patchwork qmp: netdev_add is like -netdev, not -net, fix documentation

login
register
mail settings
Submitter Markus Armbruster
Date Feb. 22, 2013, 5:31 p.m.
Message ID <1361554311-25605-1-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/222591/
State New
Headers show

Comments

Markus Armbruster - Feb. 22, 2013, 5:31 p.m.
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qmp-commands.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Laszlo Ersek - Feb. 22, 2013, 9:36 p.m.
On 02/22/13 18:31, Markus Armbruster wrote:
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qmp-commands.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 799adea..95022e2 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -822,7 +822,7 @@ Example:
>  -> { "execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
>  <- { "return": {} }
>  
> -Note: The supported device options are the same ones supported by the '-net'
> +Note: The supported device options are the same ones supported by the '-netdev'
>        command-line argument, which are listed in the '-help' output or QEMU's
>        manual
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Stefan Hajnoczi - Feb. 27, 2013, 2:55 p.m.
On Fri, Feb 22, 2013 at 06:31:51PM +0100, Markus Armbruster wrote:
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qmp-commands.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

Patch

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 799adea..95022e2 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -822,7 +822,7 @@  Example:
 -> { "execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
 <- { "return": {} }
 
-Note: The supported device options are the same ones supported by the '-net'
+Note: The supported device options are the same ones supported by the '-netdev'
       command-line argument, which are listed in the '-help' output or QEMU's
       manual