Patchwork [RFC,v2,2/4] KVM: Introduce KVM_CSS_BUS.

login
register
mail settings
Submitter Cornelia Huck
Date Feb. 22, 2013, 12:09 p.m.
Message ID <1361534989-38884-3-git-send-email-cornelia.huck@de.ibm.com>
Download mbox | patch
Permalink /patch/222521/
State New
Headers show

Comments

Cornelia Huck - Feb. 22, 2013, 12:09 p.m.
Add a new bus type for s390 css kvm io devices.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 include/linux/kvm_host.h | 1 +
 1 file changed, 1 insertion(+)
Michael S. Tsirkin - Feb. 24, 2013, 9:57 a.m.
On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote:
> Add a new bus type for s390 css kvm io devices.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>  include/linux/kvm_host.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 3b768ef..59be516 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -148,6 +148,7 @@ struct kvm_io_bus {
>  enum kvm_bus {
>  	KVM_MMIO_BUS,
>  	KVM_PIO_BUS,
> +	KVM_CSS_BUS,

so maybe KVM_S390_VIRTIO_CCW_NOTIFY_BUS

to make the fact it's s390 and virtio specific, explicit?

>  	KVM_NR_BUSES
>  };
>  
> -- 
> 1.7.12.4
Cornelia Huck - Feb. 25, 2013, 8:50 a.m.
On Sun, 24 Feb 2013 11:57:25 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote:
> > Add a new bus type for s390 css kvm io devices.
> > 
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > ---
> >  include/linux/kvm_host.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> > index 3b768ef..59be516 100644
> > --- a/include/linux/kvm_host.h
> > +++ b/include/linux/kvm_host.h
> > @@ -148,6 +148,7 @@ struct kvm_io_bus {
> >  enum kvm_bus {
> >  	KVM_MMIO_BUS,
> >  	KVM_PIO_BUS,
> > +	KVM_CSS_BUS,
> 
> so maybe KVM_S390_VIRTIO_CCW_NOTIFY_BUS
> 
> to make the fact it's s390 and virtio specific, explicit?

Hm, I don't really see a need to point out that this is s390-specific,
so I think I'd prefer KVM_VIRTIO_CCW_NOTIFY_BUS.

> 
> >  	KVM_NR_BUSES
> >  };
> >  
> > -- 
> > 1.7.12.4
>

Patch

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 3b768ef..59be516 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -148,6 +148,7 @@  struct kvm_io_bus {
 enum kvm_bus {
 	KVM_MMIO_BUS,
 	KVM_PIO_BUS,
+	KVM_CSS_BUS,
 	KVM_NR_BUSES
 };