From patchwork Fri Feb 22 09:52:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 222494 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 31EBA2C02AB for ; Fri, 22 Feb 2013 20:43:16 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E6DA54A371; Fri, 22 Feb 2013 10:43:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lo41hzHkiDre; Fri, 22 Feb 2013 10:43:10 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3A4254A321; Fri, 22 Feb 2013 10:42:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6588D4A2FD for ; Fri, 22 Feb 2013 10:42:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6+cvYu2acwfs for ; Fri, 22 Feb 2013 10:42:45 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by theia.denx.de (Postfix) with ESMTP id 92C6F4A2F4 for ; Fri, 22 Feb 2013 10:42:44 +0100 (CET) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MIM00J2A7U7U9B0@mailout1.samsung.com> for u-boot@lists.denx.de; Fri, 22 Feb 2013 18:32:35 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.123]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id F8.65.05791.33B37215; Fri, 22 Feb 2013 18:32:35 +0900 (KST) X-AuditID: cbfee690-b7f066d00000169f-0f-51273b334aa9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3A.1E.03918.C2B37215; Fri, 22 Feb 2013 18:32:28 +0900 (KST) Received: from chrome-ubuntu.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MIM00B6K7TU7A60@mmp1.samsung.com> for u-boot@lists.denx.de; Fri, 22 Feb 2013 18:32:28 +0900 (KST) From: Ajay Kumar To: u-boot@lists.denx.de Date: Fri, 22 Feb 2013 04:52:58 -0500 Message-id: <1361526789-29787-3-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1361526789-29787-1-git-send-email-ajaykumar.rs@samsung.com> References: <1361526789-29787-1-git-send-email-ajaykumar.rs@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsWyRsSkWtfYWj3QYMt7BYu3ezvZHRg9zt7Z wRjAGMVlk5Kak1mWWqRvl8CV8WzNBpaCVUIVLS9DGxiX8HcxcnJICJhIbHzYwQhhi0lcuLee rYuRi0NIYCmjxLt/71ngih7cZ4VILGKUuPrjDQuEs4xJ4sDL20wgVWwC2hLbpt8E6xARkJD4 1X8VbCyzQLjE338zwGxhAU+J63PnsYHYLAKqEpOvv2IHsXkFPCR2Hd3JBrFNTuLDnkdgcU6g +saOZrBeIaCatmuXmEAWSwhcZpM4cOIQK8QgAYlvkw8BLeYASshKbDrADDFHUuLgihssExiF FzAyrGIUTS1ILihOSi8y0StOzC0uzUvXS87P3cQIDMLT/55N2MF474D1IcZkoHETmaVEk/OB QZxXEm9obGJuamxqZmRpaWlKmrCSOK/8JZlAIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYws HsYnvZf8MpKZIdqmu5TP+vmWnin32e8EmslUZGvPWZn+M+xFzgxVDrPb8b8M50eqz3drWPrA wdVfY4/cuhN9t76d1JASvCp5mOvI6oC+Gs8LS6uKd6jkfemY2b38XuTCA3e/rj5/7rLO6pXv n+WLlPTVWq75nHHH/PSU5uKmo39Z5luyaJkpsRRnJBpqMRcVJwIAs8CgPVgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jAV0da/VAg9eTuS3e7u1kd2D0OHtn B2MAY1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0FglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8azNRtYClYJVbS8DG1g XMLfxcjJISFgIrHxwX1WCFtM4sK99WxdjFwcQgKLGCWu/njDAuEsY5I48PI2E0gVm4C2xLbp N1lAbBEBCYlf/VcZQWxmgXCJv/9mgNnCAp4S1+fOYwOxWQRUJSZff8UOYvMKeEjsOrqTDWKb nMSHPY/A4pxA9Y0dzWC9QkA1bdcuMU1g5F3AyLCKUTS1ILmgOCk911CvODG3uDQvXS85P3cT IzjEn0ntYFzZYHGIUYCDUYmHt8FFLVCINbGsuDL3EKMEB7OSCK+BhXqgEG9KYmVValF+fFFp TmrxIcZkoKsmMkuJJucD4y+vJN7Q2MTc1NjU0sTCxMySNGElcV7GU08ChATSE0tSs1NTC1KL YLYwcXBKNTDO/CJ/+7ll0YwV9S4S3XsXCKxlEF6cE1MrVZdR+klKaPWa/rkuKx8nx559Y/9y S8YL9lL/12p7WpcVRkSYejULvYyoWHM2drOGatX752+kXJhv+ei4nqxVyn9pNEm5uONAx2eX F5POHkxb8/bhTGedfLMlLlwFVcdTbas68ideTjzxLiK7X0+JpTgj0VCLuag4EQA0IqSgtQIA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: inki.dae@samsung.com, dh09.lee@samsung.com, sjg@chomium.org Subject: [U-Boot] [PATCH 02/13] video: exynos_dp: Remove callbacks from the driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Replaced the functionality of callbacks by using a standard set of functions. Instead of implementing and hooking up a callback, put the same code in one of the standard set of functions by overriding it. Signed-off-by: Ajay Kumar --- arch/arm/include/asm/arch-exynos/dp_info.h | 1 - board/samsung/smdk5250/smdk5250.c | 6 +++++- drivers/video/exynos_dp.c | 9 +++++++-- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/arch-exynos/dp_info.h b/arch/arm/include/asm/arch-exynos/dp_info.h index 102b709..ff16361 100644 --- a/arch/arm/include/asm/arch-exynos/dp_info.h +++ b/arch/arm/include/asm/arch-exynos/dp_info.h @@ -199,7 +199,6 @@ enum { struct exynos_dp_platform_data { struct edp_device_info *edp_dev_info; - void (*phy_enable)(unsigned int); }; #ifdef CONFIG_EXYNOS_DP diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c index 43673a5..9e1e5db 100644 --- a/board/samsung/smdk5250/smdk5250.c +++ b/board/samsung/smdk5250/smdk5250.c @@ -440,6 +440,11 @@ vidinfo_t panel_info = { .dp_enabled = 1, }; +void exynos_set_dp_phy(unsigned int onoff) +{ + set_dp_phy_ctrl(onoff); +} + static struct edp_device_info edp_info = { .disp_info = { .h_res = 2560, @@ -470,7 +475,6 @@ static struct edp_device_info edp_info = { }; static struct exynos_dp_platform_data dp_platform_data = { - .phy_enable = set_dp_phy_ctrl, .edp_dev_info = &edp_info, }; diff --git a/drivers/video/exynos_dp.c b/drivers/video/exynos_dp.c index d72fa56..b2accc7 100644 --- a/drivers/video/exynos_dp.c +++ b/drivers/video/exynos_dp.c @@ -32,6 +32,12 @@ static struct exynos_dp_platform_data *dp_pd; +void __exynos_set_dp_phy(unsigned int onoff) +{ +} +void exynos_set_dp_phy(unsigned int onoff) + __attribute__((weak, alias("__exynos_set_dp_phy"))); + static void exynos_dp_disp_info(struct edp_disp_info *disp_info) { disp_info->h_total = disp_info->h_res + disp_info->h_sync_width + @@ -872,8 +878,7 @@ unsigned int exynos_init_dp(void) exynos_dp_disp_info(&edp_info->disp_info); - if (dp_pd->phy_enable) - dp_pd->phy_enable(1); + exynos_set_dp_phy(1); ret = exynos_dp_init_dp(); if (ret != EXYNOS_DP_SUCCESS) {