| Submitter | Stefan Weil |
|---|---|
| Date | Feb. 22, 2013, 6:28 a.m. |
| Message ID | <1361514481-26164-1-git-send-email-sw@weilnetz.de> |
| Download | mbox | patch |
| Permalink | /patch/222472/ |
| State | Accepted |
| Headers | show |
Comments
Stefan Weil <sw@weilnetz.de> writes: > At least for Ubuntu Linux locale.h is needed. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> Thanks, what version of Ubuntu? I'm running 11.10 and don't have this problem. Regards, Anthony Liguori > --- > > This is a build regression, please apply without waiting for qemu-trivial. > > Thanks, > Stefan > > ui/gtk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ui/gtk.c b/ui/gtk.c > index 29156be..5f91de4 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -37,6 +37,7 @@ > #include <gtk/gtk.h> > #include <gdk/gdkkeysyms.h> > #include <glib/gi18n.h> > +#include <locale.h> > #include <vte/vte.h> > #include <sys/types.h> > #include <sys/socket.h> > -- > 1.7.10.4
Am 22.02.2013 14:14, schrieb Anthony Liguori: > Stefan Weil <sw@weilnetz.de> writes: > >> At least for Ubuntu Linux locale.h is needed. >> >> Signed-off-by: Stefan Weil <sw@weilnetz.de> > Thanks, what version of Ubuntu? I'm running 11.10 and don't have this > problem. > It's needed for Ubuntu Precise 12.04.2 LTS (32 bit), the latest LTS version, so QEMU should support this environment. I assume that other distributions include locale.h indirectly. The man page of setlocale explicitly says that locale.h is the required include file. Regards, Stefan Weil
Applied. Thanks. Regards, Anthony Liguori
Patch
diff --git a/ui/gtk.c b/ui/gtk.c index 29156be..5f91de4 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -37,6 +37,7 @@ #include <gtk/gtk.h> #include <gdk/gdkkeysyms.h> #include <glib/gi18n.h> +#include <locale.h> #include <vte/vte.h> #include <sys/types.h> #include <sys/socket.h>
At least for Ubuntu Linux locale.h is needed. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- This is a build regression, please apply without waiting for qemu-trivial. Thanks, Stefan ui/gtk.c | 1 + 1 file changed, 1 insertion(+)