Patchwork [1/3] ARM: tegra: Fix unchecked return value

login
register
mail settings
Submitter Joseph Lo
Date Feb. 22, 2013, 6:24 a.m.
Message ID <1361514267-12111-1-git-send-email-josephl@nvidia.com>
Download mbox | patch
Permalink /patch/222469/
State Accepted, archived
Headers show

Comments

Joseph Lo - Feb. 22, 2013, 6:24 a.m.
From: Hiroshi Doyu <hdoyu@nvidia.com>

Check a return value for tegra_powergate_remove_clamping().

Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
 arch/arm/mach-tegra/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)
Stephen Warren - March 6, 2013, 9:29 p.m.
On 02/21/2013 11:24 PM, Joseph Lo wrote:
> Check a return value for tegra_powergate_remove_clamping().

I have applied patches 1/3 and 2/3 to Tegra's for-3.10/fixes, and 3/3 to
Tegra's for-3.10/cleanup branches.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-tegra/platsmp.c b/arch/arm/mach-tegra/platsmp.c
index 2c6b3d5..4dfc75e 100644
--- a/arch/arm/mach-tegra/platsmp.c
+++ b/arch/arm/mach-tegra/platsmp.c
@@ -124,6 +124,9 @@  remove_clamps:
 
 	/* Remove I/O clamps. */
 	ret = tegra_powergate_remove_clamping(pwrgateid);
+	if (ret)
+		return ret;
+
 	udelay(10);
 
 	/* Clear flow controller CSR. */